You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/10/11 23:17:38 UTC
Review Request 62912: Added tests for RWMutex.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62912/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, and Jason Lai.
Bugs: MESOS-8075
https://issues.apache.org/jira/browse/MESOS-8075
Repository: mesos
Description
-------
Added tests for RWMutex.
Diffs
-----
3rdparty/libprocess/Makefile.am 6b2fdff375514da1285cc614c3504c4d0892e464
3rdparty/libprocess/src/tests/CMakeLists.txt d9ca23de13100619dbb6a9c0b53f78ea30d390f1
3rdparty/libprocess/src/tests/rwmutex_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/62912/diff/1/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 62912: Added tests for RWMutex.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62912/#review188437
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62911, 62912]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 17, 2017, 12:56 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62912/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 12:56 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, and Jason Lai.
>
>
> Bugs: MESOS-8075
> https://issues.apache.org/jira/browse/MESOS-8075
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for RWMutex.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am c5bfe6d62d8a93942146feb07e8423eebd70f1de
> 3rdparty/libprocess/src/tests/CMakeLists.txt d9ca23de13100619dbb6a9c0b53f78ea30d390f1
> 3rdparty/libprocess/src/tests/rwmutex_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62912/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 62912: Added tests for ReadWriteLock.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62912/#review188769
-----------------------------------------------------------
Fix it, then Ship it!
I made some minor tweaks to the code, thanks for writing tests!
3rdparty/libprocess/src/tests/rwlock_tests.cpp
Lines 13 (patched)
<https://reviews.apache.org/r/62912/#comment265777>
I don't think you're doing any mocking here, should just need the gtest header.
- Benjamin Mahler
On Oct. 19, 2017, 4:25 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62912/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 4:25 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, and Jason Lai.
>
>
> Bugs: MESOS-8075
> https://issues.apache.org/jira/browse/MESOS-8075
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for ReadWriteLock.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am c5bfe6d62d8a93942146feb07e8423eebd70f1de
> 3rdparty/libprocess/src/tests/CMakeLists.txt d9ca23de13100619dbb6a9c0b53f78ea30d390f1
> 3rdparty/libprocess/src/tests/rwlock_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62912/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 62912: Added tests for ReadWriteLock.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62912/
-----------------------------------------------------------
(Updated Oct. 19, 2017, 4:25 p.m.)
Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, and Jason Lai.
Changes
-------
Updated tests.
Summary (updated)
-----------------
Added tests for ReadWriteLock.
Bugs: MESOS-8075
https://issues.apache.org/jira/browse/MESOS-8075
Repository: mesos
Description (updated)
-------
Added tests for ReadWriteLock.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am c5bfe6d62d8a93942146feb07e8423eebd70f1de
3rdparty/libprocess/src/tests/CMakeLists.txt d9ca23de13100619dbb6a9c0b53f78ea30d390f1
3rdparty/libprocess/src/tests/rwlock_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/62912/diff/3/
Changes: https://reviews.apache.org/r/62912/diff/2-3/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 62912: Added tests for RWMutex.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62912/#review188434
-----------------------------------------------------------
PASS: Mesos patch 62912 was successfully built and tested.
Reviews applied: `['62911', '62912']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62912
- Mesos Reviewbot Windows
On Oct. 17, 2017, 7:56 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62912/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 7:56 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, and Jason Lai.
>
>
> Bugs: MESOS-8075
> https://issues.apache.org/jira/browse/MESOS-8075
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for RWMutex.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am c5bfe6d62d8a93942146feb07e8423eebd70f1de
> 3rdparty/libprocess/src/tests/CMakeLists.txt d9ca23de13100619dbb6a9c0b53f78ea30d390f1
> 3rdparty/libprocess/src/tests/rwmutex_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62912/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 62912: Added tests for RWMutex.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62912/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 7:56 p.m.)
Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, and Jason Lai.
Changes
-------
Rebase.
Bugs: MESOS-8075
https://issues.apache.org/jira/browse/MESOS-8075
Repository: mesos
Description
-------
Added tests for RWMutex.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am c5bfe6d62d8a93942146feb07e8423eebd70f1de
3rdparty/libprocess/src/tests/CMakeLists.txt d9ca23de13100619dbb6a9c0b53f78ea30d390f1
3rdparty/libprocess/src/tests/rwmutex_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/62912/diff/2/
Changes: https://reviews.apache.org/r/62912/diff/1-2/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 62912: Added tests for RWMutex.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62912/#review187734
-----------------------------------------------------------
PASS: Mesos patch 62912 was successfully built and tested.
Reviews applied: `['62911', '62912']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62912
- Mesos Reviewbot Windows
On Oct. 11, 2017, 11:17 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62912/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2017, 11:17 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, and Jason Lai.
>
>
> Bugs: MESOS-8075
> https://issues.apache.org/jira/browse/MESOS-8075
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for RWMutex.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 6b2fdff375514da1285cc614c3504c4d0892e464
> 3rdparty/libprocess/src/tests/CMakeLists.txt d9ca23de13100619dbb6a9c0b53f78ea30d390f1
> 3rdparty/libprocess/src/tests/rwmutex_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62912/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>