You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/23 17:39:15 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #4343: Minor: Add docstrings to `EliminateOuterJoins`
alamb opened a new pull request, #4343:
URL: https://github.com/apache/arrow-datafusion/pull/4343
# Which issue does this PR close?
re https://github.com/apache/arrow-datafusion/pull/4272
# Rationale for this change
I noticed in https://github.com/apache/arrow-datafusion/pull/4272 from @jackwener that some comments were lost. I found this kind of rewrite somewhat mind bending, so figured I would put them back
# What changes are included in this PR?
Add docstrings to `EliminateOuterJoins`
# Are these changes tested?
No
# Are there any user-facing changes?
Not really
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4343: Minor: Add docstrings to `EliminateOuterJoins` optimizer pass
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4343:
URL: https://github.com/apache/arrow-datafusion/pull/4343#issuecomment-1326336416
Benchmark runs are scheduled for baseline = 561be4fda2ed3abac038cf422cb7b03d443748de and contender = e1204a5bf72c119123404463befb716adbdcff25. e1204a5bf72c119123404463befb716adbdcff25 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/39bad7052b3b473cb315c834fdcb91e3...8ed0f886a903406aabacc619934a1e10/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d6afe4f2ffe14143a523094e1b45f8e9...76204f17489d4f04a609d6c412c02397/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d3d76e633c554f5c93838b741efb0857...1b18a5cf8d1040558b7c969b3d4c96ff/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a138fe9c55c746529bd22d6647b21e31...427bd059bb6645afadb21cfd3e3f8c18/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4343: Minor: Add docstrings to `EliminateOuterJoins` optimizer pass
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4343:
URL: https://github.com/apache/arrow-datafusion/pull/4343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org