[GitHub] [pinot] KKcorps commented on a diff in pull request #9424: refactor LLRealtimeSegmentDataManager

[GitBox <gi...@apache.org>]

KKcorps commented on code in PR #9424:
URL: https://github.com/apache/pinot/pull/9424#discussion_r973900800


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -288,7 +285,7 @@ public void deleteSegmentFile() {
   private final SegmentCommitterFactory _segmentCommitterFactory;
   private final ConsumptionRateLimiter _rateLimiter;
 
-  private volatile StreamPartitionMsgOffset _latestStreamOffsetAtStartupTime = null;
+  private final StreamPartitionMsgOffset _latestStreamOffsetAtStartupTime;

Review Comment:
   Is this variable not being modified anywhere?



##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/converter/ColumnDescriptionsContainer.java:
##########
@@ -0,0 +1,48 @@
+package org.apache.pinot.segment.local.realtime.converter;
+
+import java.util.List;
+
+
+public class ColumnDescriptionsContainer {
+  private final String _sortedColumn;
+  private final List<String> _invertedIndexColumns;
+  private final List<String> _textIndexColumns;
+  private final List<String> _fstIndexColumns;
+  private final List<String> _noDictionaryColumns;
+  private final List<String> _varLengthDictionaryColumns;
+
+  public ColumnDescriptionsContainer(String sortedColumn, List<String> invertedIndexColumns,
+      List<String> textIndexColumns, List<String> fstIndexColumns, List<String> noDictionaryColumns,
+      List<String> varLengthDictionaryColumns) {
+    _sortedColumn = sortedColumn;
+    _invertedIndexColumns = invertedIndexColumns;
+    _textIndexColumns = textIndexColumns;
+    _fstIndexColumns = fstIndexColumns;
+    _noDictionaryColumns = noDictionaryColumns;
+    _varLengthDictionaryColumns = varLengthDictionaryColumns;
+  }
+
+  public String getSortedColumn() {
+    return _sortedColumn;
+  }
+
+  public List<String> getInvertedIndexColumns() {
+    return _invertedIndexColumns;
+  }
+
+  public List<String> getTextIndexColumns() {
+    return _textIndexColumns;
+  }
+
+  public List<String> getFstIndexColumns() {
+    return _fstIndexColumns;
+  }
+
+  public List<String> getNoDictionaryColumns() {

Review Comment:
   Seems like this method is not being used anywhere but it should ideally be used.



##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -1529,7 +1521,7 @@ private void makeStreamMetadataProvider(String reason) {
       closeStreamMetadataProvider();
     }
     _segmentLogger.info("Creating new stream metadata provider, reason: {}", reason);

Review Comment:
   ```suggestion
       _segmentLogger.info("Creating new partition metadata provider, reason: {}", reason);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org