You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "James Dyer (JIRA)" <ji...@apache.org> on 2012/04/28 00:06:50 UTC
[jira] [Created] (SOLR-3422) Refactor DIH - configuration data
James Dyer created SOLR-3422:
--------------------------------
Summary: Refactor DIH - configuration data
Key: SOLR-3422
URL: https://issues.apache.org/jira/browse/SOLR-3422
Project: Solr
Issue Type: Improvement
Components: contrib - DataImportHandler
Affects Versions: 4.0
Reporter: James Dyer
Assignee: James Dyer
Priority: Minor
Fix For: 4.0
In my spare time, I would like to try and make DIH into something that is a Joy to Maintain.
Here's a tiny first step: put the configuration data into immutable classes, moving state data elsewhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3422) Refactor DIH - configuration data
Posted by "Mikhail Khludnev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264236#comment-13264236 ]
Mikhail Khludnev commented on SOLR-3422:
----------------------------------------
bq. All DIH tests pass,
I'm sorry for hijacking, but I want to remind that important test cases from SOLR-3360 should be committed.
> Refactor DIH - configuration data
> ---------------------------------
>
> Key: SOLR-3422
> URL: https://issues.apache.org/jira/browse/SOLR-3422
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3422.patch
>
>
> In my spare time, I would like to try and make DIH into something that is a Joy to Maintain.
> Here's a tiny first step: put the configuration data into immutable classes, moving state data elsewhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3422) Refactor DIH - configuration data
Posted by "James Dyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer updated SOLR-3422:
-----------------------------
Attachment: SOLR-3422.patch
This is a big patch file, but it mostly is just moving things around.
All DIH tests pass, and I plan on committing this shortly.
> Refactor DIH - configuration data
> ---------------------------------
>
> Key: SOLR-3422
> URL: https://issues.apache.org/jira/browse/SOLR-3422
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3422.patch
>
>
> In my spare time, I would like to try and make DIH into something that is a Joy to Maintain.
> Here's a tiny first step: put the configuration data into immutable classes, moving state data elsewhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3422) Refactor DIH - configuration data
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264047#comment-13264047 ]
Mark Miller commented on SOLR-3422:
-----------------------------------
bq. In my spare time, I would like to try and make DIH into something that is a Joy to Maintain
+1 - nice.
> Refactor DIH - configuration data
> ---------------------------------
>
> Key: SOLR-3422
> URL: https://issues.apache.org/jira/browse/SOLR-3422
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3422.patch
>
>
> In my spare time, I would like to try and make DIH into something that is a Joy to Maintain.
> Here's a tiny first step: put the configuration data into immutable classes, moving state data elsewhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3422) Refactor DIH - configuration data
Posted by "James Dyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer updated SOLR-3422:
-----------------------------
Attachment: SOLR-3422.patch
updated patch.
> Refactor DIH - configuration data
> ---------------------------------
>
> Key: SOLR-3422
> URL: https://issues.apache.org/jira/browse/SOLR-3422
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3422.patch, SOLR-3422.patch
>
>
> In my spare time, I would like to try and make DIH into something that is a Joy to Maintain.
> Here's a tiny first step: put the configuration data into immutable classes, moving state data elsewhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3422) Refactor DIH - configuration data
Posted by "James Dyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer resolved SOLR-3422.
------------------------------
Resolution: Fixed
Committed to Trunk, r1332292.
> Refactor DIH - configuration data
> ---------------------------------
>
> Key: SOLR-3422
> URL: https://issues.apache.org/jira/browse/SOLR-3422
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3422.patch, SOLR-3422.patch
>
>
> In my spare time, I would like to try and make DIH into something that is a Joy to Maintain.
> Here's a tiny first step: put the configuration data into immutable classes, moving state data elsewhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org