You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Pierre Smits <pi...@gmail.com> on 2012/05/31 10:13:28 UTC
Re: svn commit: r1344568 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
Please revert this as this is not fixing an error. There was no error to
begin with.
This commit only reflects a different viewpoint on what the function of the
screen should be.
2012/5/31 <mo...@apache.org>
> Author: mor
> Date: Thu May 31 05:29:45 2012
> New Revision: 1344568
>
> URL: http://svn.apache.org/viewvc?rev=1344568&view=rev
> Log:
> Cost Center screen under Global GL Settings menu should only show accounts
> associated to cost centers and not every account related to the
> organization party.
>
> Modified:
>
> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
>
> Modified:
> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml?rev=1344568&r1=1344567&r2=1344568&view=diff
>
> ==============================================================================
> ---
> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
> (original)
> +++
> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
> Thu May 31 05:29:45 2012
> @@ -2860,11 +2860,6 @@ under the License.
> </entity-and>
> <if-not-empty field="glAccountCategories">
> <iterate list="glAccountOrganizations"
> entry="glAccountOrganization">
> - <clear-field field="glAcctgOrgAndCostCenterMap"/>
> - <get-related-one value-field="glAccountOrganization"
> relation-name="GlAccount" to-value-field="glAccount"/>
> - <set field="glAcctgOrgAndCostCenterMap.glAccountId"
> from-field="glAccount.glAccountId"/>
> - <set field="glAcctgOrgAndCostCenterMap.accountCode"
> from-field="glAccount.accountCode"/>
> - <set field="glAcctgOrgAndCostCenterMap.accountName"
> from-field="glAccount.accountName"/>
> <iterate list="glAccountCategories"
> entry="glAccountCategory">
> <entity-and entity-name="GlAccountCategoryMember"
> list="glAccountCategoryMembers" filter-by-date="true">
> <field-map field-name="glAccountId"
> from-field="glAccountOrganization.glAccountId"/>
> @@ -2872,12 +2867,15 @@ under the License.
> </entity-and>
> <if-not-empty field="glAccountCategoryMembers">
> <first-from-list
> list="glAccountCategoryMembers" entry="glAccountCategoryMember"/>
> - <if-not-empty field="glAccountCategoryMember">
> - <set
> field="glAcctgOrgAndCostCenterMap[glAccountCategory.glAccountCategoryId]"
> from-field="glAccountCategoryMember.amountPercentage" type="BigDecimal"/>
> - </if-not-empty>
> + <set
> field="glAcctgOrgAndCostCenterMap[glAccountCategory.glAccountCategoryId]"
> from-field="glAccountCategoryMember.amountPercentage" type="BigDecimal"/>
> + <get-related-one
> value-field="glAccountCategoryMember" relation-name="GlAccount"
> to-value-field="glAccount"/>
> + <set
> field="glAcctgOrgAndCostCenterMap.glAccountId"
> from-field="glAccount.glAccountId"/>
> + <set
> field="glAcctgOrgAndCostCenterMap.accountCode"
> from-field="glAccount.accountCode"/>
> + <set
> field="glAcctgOrgAndCostCenterMap.accountName"
> from-field="glAccount.accountName"/>
> </if-not-empty>
> </iterate>
> <field-to-list field="glAcctgOrgAndCostCenterMap"
> list="glAcctgAndAmountPercentageList"/>
> + <clear-field field="glAcctgOrgAndCostCenterMap"/>
> </iterate>
> <field-to-result field="glAccountCategories"/>
> </if-not-empty>
>
>
>
Re: svn commit: r1344568 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
Posted by Scott Gray <sc...@hotwaxmedia.com>.
1. I asked for a better explanation of the problem you see with this commit, I actually prefer to have every commit scrutinized by anyone who is willing.
2. The same set of rules don't apply to committers and community members, hence the commit access granted to committers through the meritocratic system. Committers have earned the right to question a commit and expect a reply, PMC members even more so to the point that they can request a revert and expect it to be done. It is always polite to reply to any comments on a commit regardless of who they are from but it isn't a requirement and you would do well to remember that when you seek a reply you are taking up a committers time and it would be polite to be as clear as possible.
3. No I simply requested that you provide more information because I don't see what the problem is and you were very brief. You also requested a revert based on that very brief comment so I pointed out to you can't request a revert particularly without having clearly articulated your position.
I'm not here to battle with you Pierre and I have no desire to do so, if you want to comment on commits I have no problem with that but please explain yourself better before requesting strong action.
On 31/05/2012, at 9:36 PM, Pierre Smits wrote:
> Scott,
>
> Thanks again for pointing out that:
>
> 1. committers can and do implement changes without scrutiny from the
> community,
> 2. this project has no PMC that ensures that the same set of rules apply
> to both committers and other community members.
> 3. you tend to make up the rules as you see fit.
>
>
> 2012/5/31 Scott Gray <sc...@hotwaxmedia.com>
>
>> Pierre, you'll need to do a better job of articulating your opinion if you
>> want a committer to take it into account. Only PMC members can request a
>> revert with little explanation (although that rarely happens, if ever).
>>
>> Regards
>> Scott
>>
>> On 31/05/2012, at 8:13 PM, Pierre Smits wrote:
>>
>>> Please revert this as this is not fixing an error. There was no error to
>>> begin with.
>>>
>>> This commit only reflects a different viewpoint on what the function of
>> the
>>> screen should be.
>>>
>>>
>>> 2012/5/31 <mo...@apache.org>
>>>
>>>> Author: mor
>>>> Date: Thu May 31 05:29:45 2012
>>>> New Revision: 1344568
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1344568&view=rev
>>>> Log:
>>>> Cost Center screen under Global GL Settings menu should only show
>> accounts
>>>> associated to cost centers and not every account related to the
>>>> organization party.
>>>>
>>>> Modified:
>>>>
>>>>
>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
>>>>
>>>> Modified:
>>>>
>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
>>>> URL:
>>>>
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml?rev=1344568&r1=1344567&r2=1344568&view=diff
>>>>
>>>>
>> ==============================================================================
>>>> ---
>>>>
>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
>>>> (original)
>>>> +++
>>>>
>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
>>>> Thu May 31 05:29:45 2012
>>>> @@ -2860,11 +2860,6 @@ under the License.
>>>> </entity-and>
>>>> <if-not-empty field="glAccountCategories">
>>>> <iterate list="glAccountOrganizations"
>>>> entry="glAccountOrganization">
>>>> - <clear-field field="glAcctgOrgAndCostCenterMap"/>
>>>> - <get-related-one
>> value-field="glAccountOrganization"
>>>> relation-name="GlAccount" to-value-field="glAccount"/>
>>>> - <set field="glAcctgOrgAndCostCenterMap.glAccountId"
>>>> from-field="glAccount.glAccountId"/>
>>>> - <set field="glAcctgOrgAndCostCenterMap.accountCode"
>>>> from-field="glAccount.accountCode"/>
>>>> - <set field="glAcctgOrgAndCostCenterMap.accountName"
>>>> from-field="glAccount.accountName"/>
>>>> <iterate list="glAccountCategories"
>>>> entry="glAccountCategory">
>>>> <entity-and entity-name="GlAccountCategoryMember"
>>>> list="glAccountCategoryMembers" filter-by-date="true">
>>>> <field-map field-name="glAccountId"
>>>> from-field="glAccountOrganization.glAccountId"/>
>>>> @@ -2872,12 +2867,15 @@ under the License.
>>>> </entity-and>
>>>> <if-not-empty field="glAccountCategoryMembers">
>>>> <first-from-list
>>>> list="glAccountCategoryMembers" entry="glAccountCategoryMember"/>
>>>> - <if-not-empty
>> field="glAccountCategoryMember">
>>>> - <set
>>>>
>> field="glAcctgOrgAndCostCenterMap[glAccountCategory.glAccountCategoryId]"
>>>> from-field="glAccountCategoryMember.amountPercentage"
>> type="BigDecimal"/>
>>>> - </if-not-empty>
>>>> + <set
>>>>
>> field="glAcctgOrgAndCostCenterMap[glAccountCategory.glAccountCategoryId]"
>>>> from-field="glAccountCategoryMember.amountPercentage"
>> type="BigDecimal"/>
>>>> + <get-related-one
>>>> value-field="glAccountCategoryMember" relation-name="GlAccount"
>>>> to-value-field="glAccount"/>
>>>> + <set
>>>> field="glAcctgOrgAndCostCenterMap.glAccountId"
>>>> from-field="glAccount.glAccountId"/>
>>>> + <set
>>>> field="glAcctgOrgAndCostCenterMap.accountCode"
>>>> from-field="glAccount.accountCode"/>
>>>> + <set
>>>> field="glAcctgOrgAndCostCenterMap.accountName"
>>>> from-field="glAccount.accountName"/>
>>>> </if-not-empty>
>>>> </iterate>
>>>> <field-to-list field="glAcctgOrgAndCostCenterMap"
>>>> list="glAcctgAndAmountPercentageList"/>
>>>> + <clear-field field="glAcctgOrgAndCostCenterMap"/>
>>>> </iterate>
>>>> <field-to-result field="glAccountCategories"/>
>>>> </if-not-empty>
>>>>
>>>>
>>>>
>>
>>
Re: svn commit: r1344568 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
Posted by Pierre Smits <pi...@gmail.com>.
Scott,
Thanks again for pointing out that:
1. committers can and do implement changes without scrutiny from the
community,
2. this project has no PMC that ensures that the same set of rules apply
to both committers and other community members.
3. you tend to make up the rules as you see fit.
2012/5/31 Scott Gray <sc...@hotwaxmedia.com>
> Pierre, you'll need to do a better job of articulating your opinion if you
> want a committer to take it into account. Only PMC members can request a
> revert with little explanation (although that rarely happens, if ever).
>
> Regards
> Scott
>
> On 31/05/2012, at 8:13 PM, Pierre Smits wrote:
>
> > Please revert this as this is not fixing an error. There was no error to
> > begin with.
> >
> > This commit only reflects a different viewpoint on what the function of
> the
> > screen should be.
> >
> >
> > 2012/5/31 <mo...@apache.org>
> >
> >> Author: mor
> >> Date: Thu May 31 05:29:45 2012
> >> New Revision: 1344568
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1344568&view=rev
> >> Log:
> >> Cost Center screen under Global GL Settings menu should only show
> accounts
> >> associated to cost centers and not every account related to the
> >> organization party.
> >>
> >> Modified:
> >>
> >>
> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
> >>
> >> Modified:
> >>
> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
> >> URL:
> >>
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml?rev=1344568&r1=1344567&r2=1344568&view=diff
> >>
> >>
> ==============================================================================
> >> ---
> >>
> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
> >> (original)
> >> +++
> >>
> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
> >> Thu May 31 05:29:45 2012
> >> @@ -2860,11 +2860,6 @@ under the License.
> >> </entity-and>
> >> <if-not-empty field="glAccountCategories">
> >> <iterate list="glAccountOrganizations"
> >> entry="glAccountOrganization">
> >> - <clear-field field="glAcctgOrgAndCostCenterMap"/>
> >> - <get-related-one
> value-field="glAccountOrganization"
> >> relation-name="GlAccount" to-value-field="glAccount"/>
> >> - <set field="glAcctgOrgAndCostCenterMap.glAccountId"
> >> from-field="glAccount.glAccountId"/>
> >> - <set field="glAcctgOrgAndCostCenterMap.accountCode"
> >> from-field="glAccount.accountCode"/>
> >> - <set field="glAcctgOrgAndCostCenterMap.accountName"
> >> from-field="glAccount.accountName"/>
> >> <iterate list="glAccountCategories"
> >> entry="glAccountCategory">
> >> <entity-and entity-name="GlAccountCategoryMember"
> >> list="glAccountCategoryMembers" filter-by-date="true">
> >> <field-map field-name="glAccountId"
> >> from-field="glAccountOrganization.glAccountId"/>
> >> @@ -2872,12 +2867,15 @@ under the License.
> >> </entity-and>
> >> <if-not-empty field="glAccountCategoryMembers">
> >> <first-from-list
> >> list="glAccountCategoryMembers" entry="glAccountCategoryMember"/>
> >> - <if-not-empty
> field="glAccountCategoryMember">
> >> - <set
> >>
> field="glAcctgOrgAndCostCenterMap[glAccountCategory.glAccountCategoryId]"
> >> from-field="glAccountCategoryMember.amountPercentage"
> type="BigDecimal"/>
> >> - </if-not-empty>
> >> + <set
> >>
> field="glAcctgOrgAndCostCenterMap[glAccountCategory.glAccountCategoryId]"
> >> from-field="glAccountCategoryMember.amountPercentage"
> type="BigDecimal"/>
> >> + <get-related-one
> >> value-field="glAccountCategoryMember" relation-name="GlAccount"
> >> to-value-field="glAccount"/>
> >> + <set
> >> field="glAcctgOrgAndCostCenterMap.glAccountId"
> >> from-field="glAccount.glAccountId"/>
> >> + <set
> >> field="glAcctgOrgAndCostCenterMap.accountCode"
> >> from-field="glAccount.accountCode"/>
> >> + <set
> >> field="glAcctgOrgAndCostCenterMap.accountName"
> >> from-field="glAccount.accountName"/>
> >> </if-not-empty>
> >> </iterate>
> >> <field-to-list field="glAcctgOrgAndCostCenterMap"
> >> list="glAcctgAndAmountPercentageList"/>
> >> + <clear-field field="glAcctgOrgAndCostCenterMap"/>
> >> </iterate>
> >> <field-to-result field="glAccountCategories"/>
> >> </if-not-empty>
> >>
> >>
> >>
>
>
Re: svn commit: r1344568 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
Posted by Scott Gray <sc...@hotwaxmedia.com>.
Pierre, you'll need to do a better job of articulating your opinion if you want a committer to take it into account. Only PMC members can request a revert with little explanation (although that rarely happens, if ever).
Regards
Scott
On 31/05/2012, at 8:13 PM, Pierre Smits wrote:
> Please revert this as this is not fixing an error. There was no error to
> begin with.
>
> This commit only reflects a different viewpoint on what the function of the
> screen should be.
>
>
> 2012/5/31 <mo...@apache.org>
>
>> Author: mor
>> Date: Thu May 31 05:29:45 2012
>> New Revision: 1344568
>>
>> URL: http://svn.apache.org/viewvc?rev=1344568&view=rev
>> Log:
>> Cost Center screen under Global GL Settings menu should only show accounts
>> associated to cost centers and not every account related to the
>> organization party.
>>
>> Modified:
>>
>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
>>
>> Modified:
>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml?rev=1344568&r1=1344567&r2=1344568&view=diff
>>
>> ==============================================================================
>> ---
>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
>> (original)
>> +++
>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
>> Thu May 31 05:29:45 2012
>> @@ -2860,11 +2860,6 @@ under the License.
>> </entity-and>
>> <if-not-empty field="glAccountCategories">
>> <iterate list="glAccountOrganizations"
>> entry="glAccountOrganization">
>> - <clear-field field="glAcctgOrgAndCostCenterMap"/>
>> - <get-related-one value-field="glAccountOrganization"
>> relation-name="GlAccount" to-value-field="glAccount"/>
>> - <set field="glAcctgOrgAndCostCenterMap.glAccountId"
>> from-field="glAccount.glAccountId"/>
>> - <set field="glAcctgOrgAndCostCenterMap.accountCode"
>> from-field="glAccount.accountCode"/>
>> - <set field="glAcctgOrgAndCostCenterMap.accountName"
>> from-field="glAccount.accountName"/>
>> <iterate list="glAccountCategories"
>> entry="glAccountCategory">
>> <entity-and entity-name="GlAccountCategoryMember"
>> list="glAccountCategoryMembers" filter-by-date="true">
>> <field-map field-name="glAccountId"
>> from-field="glAccountOrganization.glAccountId"/>
>> @@ -2872,12 +2867,15 @@ under the License.
>> </entity-and>
>> <if-not-empty field="glAccountCategoryMembers">
>> <first-from-list
>> list="glAccountCategoryMembers" entry="glAccountCategoryMember"/>
>> - <if-not-empty field="glAccountCategoryMember">
>> - <set
>> field="glAcctgOrgAndCostCenterMap[glAccountCategory.glAccountCategoryId]"
>> from-field="glAccountCategoryMember.amountPercentage" type="BigDecimal"/>
>> - </if-not-empty>
>> + <set
>> field="glAcctgOrgAndCostCenterMap[glAccountCategory.glAccountCategoryId]"
>> from-field="glAccountCategoryMember.amountPercentage" type="BigDecimal"/>
>> + <get-related-one
>> value-field="glAccountCategoryMember" relation-name="GlAccount"
>> to-value-field="glAccount"/>
>> + <set
>> field="glAcctgOrgAndCostCenterMap.glAccountId"
>> from-field="glAccount.glAccountId"/>
>> + <set
>> field="glAcctgOrgAndCostCenterMap.accountCode"
>> from-field="glAccount.accountCode"/>
>> + <set
>> field="glAcctgOrgAndCostCenterMap.accountName"
>> from-field="glAccount.accountName"/>
>> </if-not-empty>
>> </iterate>
>> <field-to-list field="glAcctgOrgAndCostCenterMap"
>> list="glAcctgAndAmountPercentageList"/>
>> + <clear-field field="glAcctgOrgAndCostCenterMap"/>
>> </iterate>
>> <field-to-result field="glAccountCategories"/>
>> </if-not-empty>
>>
>>
>>