You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Robbie Gemmell <ro...@gmail.com> on 2011/03/04 15:39:04 UTC
Request for inclusion in 0.10 - QPID-3110
Hi Justin, all
I would like to merge the change from
https://issues.apache.org/jira/browse/QPID-3110 onto the 0.10 release
branch. It has been put on trunk already, and reviewed by Andrew Kennedy. It
is a very small change which resolves an issue introduced when fixing
QPID-3090 (when a similar change was made elsewhere, leading to a naming
mismatch between the two areas), and involves simply un-quoting the contents
of a String.
Robbie
Re: Request for inclusion in 0.10 - QPID-3110
Posted by Justin Ross <jr...@redhat.com>.
Thanks. I don't think we want to do the two steps sequentially, and an
extra jira doesn't sound nice either, so perhaps we should stick to email.
Justin
On Fri, 4 Mar 2011, Robbie Gemmell wrote:
> Thanks, I'll commit it later today.
>
> It does, you can set issues Ready To Review and then assign it to the person
> you want to review it. Although, if you need two people to review it as in
> this case, that would mean re-opening it to set it Ready To Review again for
> the second person or making sure the first reviewer assigned it to the
> second reviewer instead of just accepting it :) (Unless you meant having a
> new separate JIRA just for the approval)
>
> Robbie
>
> On 4 March 2011 14:48, Justin Ross <jr...@redhat.com> wrote:
>
>> Hi, Robbie. Approved.
>>
>> By the way, this brings up a question for me about jira. Does it have a
>> way of saying "this issue needs input from $someone"? And if so, is it easy
>> enough to use that we should consider using it for requesting approvals?
>>
>> Justin
>>
>>
>> On Fri, 4 Mar 2011, Robbie Gemmell wrote:
>>
>> Hi Justin, all
>>>
>>> I would like to merge the change from
>>> https://issues.apache.org/jira/browse/QPID-3110 onto the 0.10 release
>>> branch. It has been put on trunk already, and reviewed by Andrew Kennedy.
>>> It
>>> is a very small change which resolves an issue introduced when fixing
>>> QPID-3090 (when a similar change was made elsewhere, leading to a naming
>>> mismatch between the two areas), and involves simply un-quoting the
>>> contents
>>> of a String.
>>>
>>> Robbie
>>>
>>>
>> ---------------------------------------------------------------------
>> Apache Qpid - AMQP Messaging Implementation
>> Project: http://qpid.apache.org
>> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>>
>>
>
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: Request for inclusion in 0.10 - QPID-3110
Posted by Robbie Gemmell <ro...@gmail.com>.
Thanks, I'll commit it later today.
It does, you can set issues Ready To Review and then assign it to the person
you want to review it. Although, if you need two people to review it as in
this case, that would mean re-opening it to set it Ready To Review again for
the second person or making sure the first reviewer assigned it to the
second reviewer instead of just accepting it :) (Unless you meant having a
new separate JIRA just for the approval)
Robbie
On 4 March 2011 14:48, Justin Ross <jr...@redhat.com> wrote:
> Hi, Robbie. Approved.
>
> By the way, this brings up a question for me about jira. Does it have a
> way of saying "this issue needs input from $someone"? And if so, is it easy
> enough to use that we should consider using it for requesting approvals?
>
> Justin
>
>
> On Fri, 4 Mar 2011, Robbie Gemmell wrote:
>
> Hi Justin, all
>>
>> I would like to merge the change from
>> https://issues.apache.org/jira/browse/QPID-3110 onto the 0.10 release
>> branch. It has been put on trunk already, and reviewed by Andrew Kennedy.
>> It
>> is a very small change which resolves an issue introduced when fixing
>> QPID-3090 (when a similar change was made elsewhere, leading to a naming
>> mismatch between the two areas), and involves simply un-quoting the
>> contents
>> of a String.
>>
>> Robbie
>>
>>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
>
Re: Request for inclusion in 0.10 - QPID-3110
Posted by Justin Ross <jr...@redhat.com>.
Hi, Robbie. Approved.
By the way, this brings up a question for me about jira. Does it have a
way of saying "this issue needs input from $someone"? And if so, is it
easy enough to use that we should consider using it for requesting
approvals?
Justin
On Fri, 4 Mar 2011, Robbie Gemmell wrote:
> Hi Justin, all
>
> I would like to merge the change from
> https://issues.apache.org/jira/browse/QPID-3110 onto the 0.10 release
> branch. It has been put on trunk already, and reviewed by Andrew Kennedy. It
> is a very small change which resolves an issue introduced when fixing
> QPID-3090 (when a similar change was made elsewhere, leading to a naming
> mismatch between the two areas), and involves simply un-quoting the contents
> of a String.
>
> Robbie
>
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org