You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Enrico Olivelli <eo...@gmail.com> on 2020/02/19 17:00:53 UTC

[CANCELLED] Re: [VOTE] Apache ZooKeeper 3.6.0 candidate 3

Thank you Patrick and Mate

I have also noticed that spot bugs is failing

-1 from me

I am cancelling now this vote

I will send fixes soon

Enrico

Il Mer 19 Feb 2020, 17:05 Patrick Hunt <ph...@apache.org> ha scritto:

> The license files seem out of whack:
>
> metrics-core-3.2.5.jar
> metrics-core-5.2.5.jar_LICENSE.txt
>
> Also noticed a nit that the source artifact is not named consistently with
> previous versions: apache-zookeeper-3.5.7.tar.gz vs
> apache-zookeeper-3.6.0-source-release.tar.gz (also not consistent with the
> untarred directory name) - given the only "official" release is the source
> it seems we should be apache-zookeeper-3.6.0.tar.gz. bin seems fine.
>
> Patrick
>
> On Wed, Feb 19, 2020 at 4:09 AM Szalay-Bekő Máté <
> szalay.beko.mate@gmail.com>
> wrote:
>
> > +1 (non-binding)
> >
> > - I built the code and executed the java/C unit tests using 8u242
> > (everything passed, except PurgeTxnTest.testPurgeWhenLogRollingInProgress
> > what seems to be flaky for me... I saw it before to be flaky also on the
> > apache jenkins)
> > - Using https://github.com/symat/zk-rolling-upgrade-test
> >   - I tested rolling upgrade from 3.5.7 to 3.6.0
> >   - I tested rolling restart on 3.6.0 to enable the multi-address feature
> > with the new quorum protocol version
> > - Using https://github.com/symat/zookeeper-docker-test I also tested the
> > multi-address feature (disabling and re-enabling different virtual
> network
> > interfaces to see that the cluster always recovers)
> >
> > On Tue, Feb 18, 2020 at 7:08 PM Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > This is the fourth release candidate for Apache ZooKeeper 3.6.0.
> > >
> > > It is a major release and it introduces a lot of new features, most
> > > notably:
> > > - Built-in data consistency check inside ZooKeeper
> > > - Allow Followers to host Observers
> > > - Authentication enforcement
> > > - Pluggable metrics system for ZooKeeper (and Prometheus.io
> integration)
> > > - TLS Port unification
> > > - Audit logging in ZooKeeper servers
> > > - Improve resilience to network (advertise multiple addresses for
> > > members of a Zookeeper cluster)
> > > - Persistent Recursive Watches
> > > - add an API and the corresponding CLI to get total count of recursive
> > > sub nodes under a specific path
> > >
> > > The full release notes is available at:
> > >
> > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12326518
> > >
> > > *** Please download, test and vote by February 21th 2020, 23:59 UTC+0.
> > ***
> > >
> > > Source files:
> > > https://people.apache.org/~eolivelli/zookeeper-3.6.0-candidate-3/
> > >
> > > Maven staging repo:
> > >
> >
> https://repository.apache.org/content/repositories/orgapachezookeeper-1052/
> > >
> > > The staging version of the website is:
> > >
> >
> https://people.apache.org/~eolivelli/zookeeper-3.6.0-candidate-3/website/
> > >
> > > The release candidate tag in git to be voted upon: release-3.6.0-3
> > > https://github.com/apache/zookeeper/tree/release-3.6.0-3
> > >
> > > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > > https://www.apache.org/dist/zookeeper/KEYS
> > >
> > > Please note that we are adding a new jar to the dependency set for
> > > clients: zookeeper-metrics-providers.
> > >
> > > Should we release this candidate?
> > >
> > > Enrico Olivelli
> > >
> >
>

Re: [CANCELLED] Re: [VOTE] Apache ZooKeeper 3.6.0 candidate 3

Posted by Enrico Olivelli <eo...@gmail.com>.
Second patch, for Jackson
https://github.com/apache/zookeeper/pull/1262

Enrico

Il giorno dom 23 feb 2020 alle ore 09:57 Enrico Olivelli
<eo...@gmail.com> ha scritto:
>
> I have sent a PR with a fix for the issues found by Patrick and me
> https://github.com/apache/zookeeper/pull/1258
>
> I will also send an upgrade for Jackson as PAtrick noticed a new CVE
> https://issues.apache.org/jira/browse/ZOOKEEPER-3734
>
> Please take a look, this way I can package the new Rc4 as soon as possible
>
>
> Enrico
>
>
> Il giorno mer 19 feb 2020 alle ore 18:00 Enrico Olivelli
> <eo...@gmail.com> ha scritto:
> >
> > Thank you Patrick and Mate
> >
> > I have also noticed that spot bugs is failing
> >
> > -1 from me
> >
> > I am cancelling now this vote
> >
> > I will send fixes soon
> >
> > Enrico
> >
> > Il Mer 19 Feb 2020, 17:05 Patrick Hunt <ph...@apache.org> ha scritto:
> >>
> >> The license files seem out of whack:
> >>
> >> metrics-core-3.2.5.jar
> >> metrics-core-5.2.5.jar_LICENSE.txt
> >>
> >> Also noticed a nit that the source artifact is not named consistently with
> >> previous versions: apache-zookeeper-3.5.7.tar.gz vs
> >> apache-zookeeper-3.6.0-source-release.tar.gz (also not consistent with the
> >> untarred directory name) - given the only "official" release is the source
> >> it seems we should be apache-zookeeper-3.6.0.tar.gz. bin seems fine.
> >>
> >> Patrick
> >>
> >> On Wed, Feb 19, 2020 at 4:09 AM Szalay-Bekő Máté <sz...@gmail.com>
> >> wrote:
> >>
> >> > +1 (non-binding)
> >> >
> >> > - I built the code and executed the java/C unit tests using 8u242
> >> > (everything passed, except PurgeTxnTest.testPurgeWhenLogRollingInProgress
> >> > what seems to be flaky for me... I saw it before to be flaky also on the
> >> > apache jenkins)
> >> > - Using https://github.com/symat/zk-rolling-upgrade-test
> >> >   - I tested rolling upgrade from 3.5.7 to 3.6.0
> >> >   - I tested rolling restart on 3.6.0 to enable the multi-address feature
> >> > with the new quorum protocol version
> >> > - Using https://github.com/symat/zookeeper-docker-test I also tested the
> >> > multi-address feature (disabling and re-enabling different virtual network
> >> > interfaces to see that the cluster always recovers)
> >> >
> >> > On Tue, Feb 18, 2020 at 7:08 PM Enrico Olivelli <eo...@gmail.com>
> >> > wrote:
> >> >
> >> > > This is the fourth release candidate for Apache ZooKeeper 3.6.0.
> >> > >
> >> > > It is a major release and it introduces a lot of new features, most
> >> > > notably:
> >> > > - Built-in data consistency check inside ZooKeeper
> >> > > - Allow Followers to host Observers
> >> > > - Authentication enforcement
> >> > > - Pluggable metrics system for ZooKeeper (and Prometheus.io integration)
> >> > > - TLS Port unification
> >> > > - Audit logging in ZooKeeper servers
> >> > > - Improve resilience to network (advertise multiple addresses for
> >> > > members of a Zookeeper cluster)
> >> > > - Persistent Recursive Watches
> >> > > - add an API and the corresponding CLI to get total count of recursive
> >> > > sub nodes under a specific path
> >> > >
> >> > > The full release notes is available at:
> >> > >
> >> > >
> >> > >
> >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12326518
> >> > >
> >> > > *** Please download, test and vote by February 21th 2020, 23:59 UTC+0.
> >> > ***
> >> > >
> >> > > Source files:
> >> > > https://people.apache.org/~eolivelli/zookeeper-3.6.0-candidate-3/
> >> > >
> >> > > Maven staging repo:
> >> > >
> >> > https://repository.apache.org/content/repositories/orgapachezookeeper-1052/
> >> > >
> >> > > The staging version of the website is:
> >> > >
> >> > https://people.apache.org/~eolivelli/zookeeper-3.6.0-candidate-3/website/
> >> > >
> >> > > The release candidate tag in git to be voted upon: release-3.6.0-3
> >> > > https://github.com/apache/zookeeper/tree/release-3.6.0-3
> >> > >
> >> > > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> >> > > https://www.apache.org/dist/zookeeper/KEYS
> >> > >
> >> > > Please note that we are adding a new jar to the dependency set for
> >> > > clients: zookeeper-metrics-providers.
> >> > >
> >> > > Should we release this candidate?
> >> > >
> >> > > Enrico Olivelli
> >> > >
> >> >

Re: [CANCELLED] Re: [VOTE] Apache ZooKeeper 3.6.0 candidate 3

Posted by Enrico Olivelli <eo...@gmail.com>.
I have sent a PR with a fix for the issues found by Patrick and me
https://github.com/apache/zookeeper/pull/1258

I will also send an upgrade for Jackson as PAtrick noticed a new CVE
https://issues.apache.org/jira/browse/ZOOKEEPER-3734

Please take a look, this way I can package the new Rc4 as soon as possible


Enrico


Il giorno mer 19 feb 2020 alle ore 18:00 Enrico Olivelli
<eo...@gmail.com> ha scritto:
>
> Thank you Patrick and Mate
>
> I have also noticed that spot bugs is failing
>
> -1 from me
>
> I am cancelling now this vote
>
> I will send fixes soon
>
> Enrico
>
> Il Mer 19 Feb 2020, 17:05 Patrick Hunt <ph...@apache.org> ha scritto:
>>
>> The license files seem out of whack:
>>
>> metrics-core-3.2.5.jar
>> metrics-core-5.2.5.jar_LICENSE.txt
>>
>> Also noticed a nit that the source artifact is not named consistently with
>> previous versions: apache-zookeeper-3.5.7.tar.gz vs
>> apache-zookeeper-3.6.0-source-release.tar.gz (also not consistent with the
>> untarred directory name) - given the only "official" release is the source
>> it seems we should be apache-zookeeper-3.6.0.tar.gz. bin seems fine.
>>
>> Patrick
>>
>> On Wed, Feb 19, 2020 at 4:09 AM Szalay-Bekő Máté <sz...@gmail.com>
>> wrote:
>>
>> > +1 (non-binding)
>> >
>> > - I built the code and executed the java/C unit tests using 8u242
>> > (everything passed, except PurgeTxnTest.testPurgeWhenLogRollingInProgress
>> > what seems to be flaky for me... I saw it before to be flaky also on the
>> > apache jenkins)
>> > - Using https://github.com/symat/zk-rolling-upgrade-test
>> >   - I tested rolling upgrade from 3.5.7 to 3.6.0
>> >   - I tested rolling restart on 3.6.0 to enable the multi-address feature
>> > with the new quorum protocol version
>> > - Using https://github.com/symat/zookeeper-docker-test I also tested the
>> > multi-address feature (disabling and re-enabling different virtual network
>> > interfaces to see that the cluster always recovers)
>> >
>> > On Tue, Feb 18, 2020 at 7:08 PM Enrico Olivelli <eo...@gmail.com>
>> > wrote:
>> >
>> > > This is the fourth release candidate for Apache ZooKeeper 3.6.0.
>> > >
>> > > It is a major release and it introduces a lot of new features, most
>> > > notably:
>> > > - Built-in data consistency check inside ZooKeeper
>> > > - Allow Followers to host Observers
>> > > - Authentication enforcement
>> > > - Pluggable metrics system for ZooKeeper (and Prometheus.io integration)
>> > > - TLS Port unification
>> > > - Audit logging in ZooKeeper servers
>> > > - Improve resilience to network (advertise multiple addresses for
>> > > members of a Zookeeper cluster)
>> > > - Persistent Recursive Watches
>> > > - add an API and the corresponding CLI to get total count of recursive
>> > > sub nodes under a specific path
>> > >
>> > > The full release notes is available at:
>> > >
>> > >
>> > >
>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12326518
>> > >
>> > > *** Please download, test and vote by February 21th 2020, 23:59 UTC+0.
>> > ***
>> > >
>> > > Source files:
>> > > https://people.apache.org/~eolivelli/zookeeper-3.6.0-candidate-3/
>> > >
>> > > Maven staging repo:
>> > >
>> > https://repository.apache.org/content/repositories/orgapachezookeeper-1052/
>> > >
>> > > The staging version of the website is:
>> > >
>> > https://people.apache.org/~eolivelli/zookeeper-3.6.0-candidate-3/website/
>> > >
>> > > The release candidate tag in git to be voted upon: release-3.6.0-3
>> > > https://github.com/apache/zookeeper/tree/release-3.6.0-3
>> > >
>> > > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>> > > https://www.apache.org/dist/zookeeper/KEYS
>> > >
>> > > Please note that we are adding a new jar to the dependency set for
>> > > clients: zookeeper-metrics-providers.
>> > >
>> > > Should we release this candidate?
>> > >
>> > > Enrico Olivelli
>> > >
>> >