You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "ekuziel (via GitHub)" <gi...@apache.org> on 2023/06/02 10:28:28 UTC

[GitHub] [superset] ekuziel opened a new issue, #24274: Chart d3-format currency configuration

ekuziel opened a new issue, #24274:
URL: https://github.com/apache/superset/issues/24274

   I'm use superset container apache/superset where all resources are prepared and I want to change / add another d3-formats for numeric values like currencies Euro / Pound - currently I see only option $,.2f and I'm not able to edit it 
   
   #### How to reproduce the bug
   
   1. Go to 'Charts'
   3. Go to 'Customize' section and select in 'CUSTOMIZE COLUMNS' the numeric field and click an arrow
   4. popup for changing format will show
   
   ### Expected results
   
   to change interactively D3 format 
   
   ### Actual results
   
   I can only select from existing list of options
   
   #### Screenshots
   ![image](https://github.com/apache/superset/assets/24870533/ebbd3adb-7246-41db-85e7-dafb93434294)
   
   
   
   
   ### Environment
   
   Containerized solution apache/superset:2.1.0
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rusackas closed issue #24274: Chart d3-format currency configuration

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #24274: Chart d3-format currency configuration
URL: https://github.com/apache/superset/issues/24274


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] yousoph commented on issue #24274: Chart d3-format currency configuration

Posted by "yousoph (via GitHub)" <gi...@apache.org>.
yousoph commented on issue #24274:
URL: https://github.com/apache/superset/issues/24274#issuecomment-1652648106

   https://github.com/apache/superset/pull/24718 and https://github.com/apache/superset/pull/24517 add support for more currency symbols 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rusackas commented on issue #24274: Chart d3-format currency configuration

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #24274:
URL: https://github.com/apache/superset/issues/24274#issuecomment-1577383403

   In D3 formatter syntax, the $ is just a placeholder for the currency symbol. You cannot just drop in another currency symbol for this. Instead you would do it with a D3 "locale" which is different from a formatter. You can set this for your _entire superset instance_ in `config.py` if you're close to `master` (it has not been released in an official Apache version yet). 
   
   Given all that, just know that you're not alone... a lot of people are asking for this, and various folks are trying to find the best way forward with an implementation (cc @yousoph @mistercrunch) 
   
   For now, this all adds up to more of a feature request than a bug. I'll close this since there's [already a discussion open](https://github.com/apache/superset/discussions/18408).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org