[GitHub] [commons-imaging] kinow commented on a change in pull request #55: Add support to read multiple images from GIF

[GitBox <gi...@apache.org>]

kinow commented on a change in pull request #55: Add support to read multiple images from GIF
URL: https://github.com/apache/commons-imaging/pull/55#discussion_r340883242
 
 

 ##########
 File path: src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java
 ##########
 @@ -492,17 +502,29 @@ public Dimension getImageSize(final ByteSource byteSource, final Map<String, Obj
             throw new ImageReadException("GIF: Couldn't read ImageDescriptor");
         }
 
-        // Prefer the size information in the ImageDescriptor; it is more
-        // reliable
-        // than the size information in the header.
 
 Review comment:
   We will need to understand why the old code was using the other width/height too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services