You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by "Bruno Roustant (Jira)" <ji...@apache.org> on 2024/02/06 15:37:00 UTC

[jira] [Resolved] (SOLR-17146) Add DelegatingBackupRepository and alternative checksum verification

     [ https://issues.apache.org/jira/browse/SOLR-17146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Roustant resolved SOLR-17146.
-----------------------------------
    Fix Version/s: 9.6.0
       Resolution: Fixed

> Add DelegatingBackupRepository and alternative checksum verification
> --------------------------------------------------------------------
>
>                 Key: SOLR-17146
>                 URL: https://issues.apache.org/jira/browse/SOLR-17146
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Bruno Roustant
>            Priority: Major
>             Fix For: 9.6.0
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Currently all BackupRepository copy methods systematically verify the checksum of the index file to copy before copying it to the repository.
> This poses a problem when the file to copy cannot be verified with the standard Lucene checksum check. For example if the file was encrypted, the checkum would need to be verified in a different manner.
> We propose to
> 1- Add an optional initialization argument to disable the checksum verification (enabled by default) in each BackupRepository implementation.
> 2- Introduce an abstract DelegatingBackupDirectory to extend when we need to perform different/additional logic on top of a delegate BackupDirectory. For example, verify the checksum differently. Also, the DelegatingBackupDirectory could inject some initialization arguments when the BackupRepositoryFactory creates its delegate.
> Also make the existing TrackingBackupRepository (for tests) extend DelegatingBackupDirectory.
> 3- Add a test case to AbstractBackupRepositoryTest to ensure all implementations support disabling the checksum verification. And add a test for LocalFileSystemDirectory (not tested currently) that also extends AbstractBackupRepositoryTest.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org