[GitHub] [beam] lukecwik commented on pull request #22162: Optimize locking in several critical-path methods

[GitBox <gi...@apache.org>]

lukecwik commented on PR #22162:
URL: https://github.com/apache/beam/pull/22162#issuecomment-1177075675

   > > It would be great to add a concurrency test to ensure that things like `toString`/`populateDisplayData`/`serialize` all work when `as()` is modifying computed properties.
   > > Not sure how easy it will be since you'll need to generate classes at runtime to invoke `.as()` to.
   > 
   > Hm, yeah what did you have in mind here? I was struggling to think of anything useful to test.
   
   generate new classes in a loop that add a new getter/setter and call .as() and then set the value to a new property. At the same time have another thread in a loop continuously calling toString/populateDisplayData/serialize ensuring that we don't throw an exception.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org