You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by piotrz <pi...@gmail.com> on 2017/08/01 22:10:54 UTC
RE: [FlexJS, MDL] Menu with dataProvider and itemRenderer API
Hi Yishay,
I've analyzed your stacktrace and I think I understand why it is working in
your app and it is not in MDLExample.
As I remember from Harbs presentation from ApacheCON that your app is using
MDL library along with Basic module.
In general when someone would like to build your application using MDL
module you have to exclude default.css from Basic, cause UI is breaking up
if we will not do this.
-compiler.exclude-defaults-css-files=Basic-0.9.0-SNAPSHOT-js.swc:defaults.css
Since you probably do not have above line anywhere in your application your
list has following bead:
IBeadController:
ClassReference("org.apache.flex.html.beads.controllers.ListSingleSelectionMouseController");
Above bead emits "change" event, cause it listens to emitted by each item
click provided by bead
IBeadController:
ClassReference("org.apache.flex.html.beads.controllers.ItemRendererMouseController");
I just pushed fix for this issue, but it would be great if you could
describe in separate thread how did you combined MDL library with Basic in
your app without excluding defaults.css.
Thanks,
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-MDL-Menu-with-dataProvider-and-itemRenderer-API-tp57637p63639.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
RE: [FlexJS, MDL] Menu with dataProvider and itemRenderer API
Posted by Yishay Weiss <yi...@hotmail.com>.
I don’t think those lines would be enough for all MDL controls. We’re only using a subset.
From: piotrz<ma...@gmail.com>
Sent: Wednesday, August 2, 2017 2:02 PM
To: dev@flex.apache.org<ma...@flex.apache.org>
Subject: RE: [FlexJS, MDL] Menu with dataProvider and itemRenderer API
Yishay,
I think I will create jira and add those css to MDL in order to get rid off
that ugly line with exclusion.
Anyone seeing some danger doing that ?
Thanks,
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-MDL-Menu-with-dataProvider-and-itemRenderer-API-tp57637p63659.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
RE: [FlexJS, MDL] Menu with dataProvider and itemRenderer API
Posted by piotrz <pi...@gmail.com>.
Yishay,
I think I will create jira and add those css to MDL in order to get rid off
that ugly line with exclusion.
Anyone seeing some danger doing that ?
Thanks,
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-MDL-Menu-with-dataProvider-and-itemRenderer-API-tp57637p63659.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
RE: [FlexJS, MDL] Menu with dataProvider and itemRenderer API
Posted by Yishay Weiss <yi...@hotmail.com>.
Good catch. You’re correct that we’re not using -compiler.exclude-defaults-css-files anywhere.
We have some CSS overrides that take care of the controls we’re using. Generally, we just inspect the DOM and figure out which styles need to be fixed and add those to our CSS. Hopefully, this won’t be necessary when the good looking basic look&feel is ready.
.mdl-checkbox__label
{
font-size: 12px;
}
.mdl-slider
{
margin: 0px;
}
.mdl-textfield{
padding: 0px;
}
.mdl-button:hover{
padding: 0 16px;
border: none;
background-color: rgba(158,158,158,.2);
}
.mdl-slider__background-flex
{
margin: 0px;
/*width: calc(100% - 12px);*/
}
From: piotrz<ma...@gmail.com>
Sent: Wednesday, August 2, 2017 1:11 AM
To: dev@flex.apache.org<ma...@flex.apache.org>
Subject: RE: [FlexJS, MDL] Menu with dataProvider and itemRenderer API
Hi Yishay,
I've analyzed your stacktrace and I think I understand why it is working in
your app and it is not in MDLExample.
As I remember from Harbs presentation from ApacheCON that your app is using
MDL library along with Basic module.
In general when someone would like to build your application using MDL
module you have to exclude default.css from Basic, cause UI is breaking up
if we will not do this.
-compiler.exclude-defaults-css-files=Basic-0.9.0-SNAPSHOT-js.swc:defaults.css
Since you probably do not have above line anywhere in your application your
list has following bead:
IBeadController:
ClassReference("org.apache.flex.html.beads.controllers.ListSingleSelectionMouseController");
Above bead emits "change" event, cause it listens to emitted by each item
click provided by bead
IBeadController:
ClassReference("org.apache.flex.html.beads.controllers.ItemRendererMouseController");
I just pushed fix for this issue, but it would be great if you could
describe in separate thread how did you combined MDL library with Basic in
your app without excluding defaults.css.
Thanks,
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-MDL-Menu-with-dataProvider-and-itemRenderer-API-tp57637p63639.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.