You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/04 18:08:01 UTC
[GitHub] [spark] yuj commented on a change in pull request #29934: [SPARK-32067][K8S] Give pod template configmap a unique name
yuj commented on a change in pull request #29934:
URL: https://github.com/apache/spark/pull/29934#discussion_r499272899
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/PodTemplateConfigMapStep.scala
##########
@@ -85,3 +103,7 @@ private[spark] class PodTemplateConfigMapStep(conf: KubernetesConf)
}
}
}
+
+private[spark] object PodTemplateConfigMapStep {
+ val PODSPEC_CONFIGMAP_POSTFIX = "-podspec-configmap"
+}
Review comment:
@stijndehaes Thanks for addressing the feedback and consolidating the max name length constant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org