You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2019/12/20 14:17:07 UTC
[GitHub] [lucene-solr] bruno-roustant opened a new pull request #1106:
LUCENE-9106: UniformSplit postings format allows extension of block/line
serializers.
bruno-roustant opened a new pull request #1106: LUCENE-9106: UniformSplit postings format allows extension of block/line serializers.
URL: https://github.com/apache/lucene-solr/pull/1106
There are 4 public method signature changes in UniformSplitTermsReader, UniformSplitTermsWriter and their shared-terms extensions. However this seems to me it is still ok to push that to 8x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request
#1106: LUCENE-9106: UniformSplit postings format allows extension of
block/line serializers.
Posted by GitBox <gi...@apache.org>.
bruno-roustant commented on a change in pull request #1106: LUCENE-9106: UniformSplit postings format allows extension of block/line serializers.
URL: https://github.com/apache/lucene-solr/pull/1106#discussion_r361124327
##########
File path: lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/UniformSplitTermsReader.java
##########
@@ -68,16 +68,18 @@
* It can be used for decompression or decryption.
*/
public UniformSplitTermsReader(PostingsReaderBase postingsReader, SegmentReadState state, BlockDecoder blockDecoder) throws IOException {
- this(postingsReader, state, blockDecoder, NAME, VERSION_START, VERSION_CURRENT,
+ this(postingsReader, state, blockDecoder, new FieldMetadata.Serializer(), NAME, VERSION_START, VERSION_CURRENT,
Review comment:
Good point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] asfgit closed pull request #1106: LUCENE-9106:
UniformSplit postings format allows extension of block/line serializers.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1106: LUCENE-9106: UniformSplit postings format allows extension of block/line serializers.
URL: https://github.com/apache/lucene-solr/pull/1106
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1106:
LUCENE-9106: UniformSplit postings format allows extension of block/line
serializers.
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #1106: LUCENE-9106: UniformSplit postings format allows extension of block/line serializers.
URL: https://github.com/apache/lucene-solr/pull/1106#discussion_r361070689
##########
File path: lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/UniformSplitTermsReader.java
##########
@@ -68,16 +68,18 @@
* It can be used for decompression or decryption.
*/
public UniformSplitTermsReader(PostingsReaderBase postingsReader, SegmentReadState state, BlockDecoder blockDecoder) throws IOException {
- this(postingsReader, state, blockDecoder, NAME, VERSION_START, VERSION_CURRENT,
+ this(postingsReader, state, blockDecoder, new FieldMetadata.Serializer(), NAME, VERSION_START, VERSION_CURRENT,
Review comment:
Since it appears the default instance has no state, can't we re-use a shared static instance of this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org