You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/11/15 21:22:46 UTC
[GitHub] [solr] risdenk opened a new pull request, #1181: speed up javac and error-prone tasks by using less resources (#11927)
risdenk opened a new pull request, #1181:
URL: https://github.com/apache/solr/pull/1181
Ports over https://github.com/apache/lucene/pull/11927 to Solr
* pass jvm args to javac #11925
* Update net.ltgt.errorprone to the latest version so that jvm args are not overwritten, add -XX:+PrintFlagsFinal for debugging
* speed up the pure javac case too
It does not help to fork additional VMs (although error-prone will do this since it messes with bootstrap classpath), so we avoid forking.
Instead it is best to tune org.gradle.jvmargs.
* use the flags consistently everywhere (tests and doc)
Co-authored-by: Robert Muir <rm...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1181: speed up javac and error-prone tasks by using less resources (#11927)
Posted by GitBox <gi...@apache.org>.
risdenk merged PR #1181:
URL: https://github.com/apache/solr/pull/1181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] rmuir commented on pull request #1181: speed up javac and error-prone tasks by using less resources (#11927)
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #1181:
URL: https://github.com/apache/solr/pull/1181#issuecomment-1316130653
Here's the additional commit needed: https://github.com/apache/lucene/pull/11937/commits/7952d00210a9976a7cab4c6efdf8a290d03a0018
Since I don't think solr build has fancy MR-JAR stuff, you need not worry about the `compileMain19Java` case and can remove that. But you need the other two cases (basically it is whether `java` or `javac` is being run, flags need to be passed differently).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1181: speed up javac and error-prone tasks by using less resources (#11927)
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1181:
URL: https://github.com/apache/solr/pull/1181#issuecomment-1317199838
Thanks @rmuir - I grabbed the latest changes from Dawid and you as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1181: speed up javac and error-prone tasks by using less resources (#11927)
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1181:
URL: https://github.com/apache/solr/pull/1181#issuecomment-1319078599
This looks to have saved 2 min off github actions check. ~12min -> 10min for the check specific part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] rmuir commented on pull request #1181: speed up javac and error-prone tasks by using less resources (#11927)
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #1181:
URL: https://github.com/apache/solr/pull/1181#issuecomment-1316015002
@risdenk I had to revert it for now (see PR). Needs a tweak to handle alternate toolchain (e.g. the EA-testing that policeman jenkins does)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org