You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@archiva.apache.org by jm...@apache.org on 2007/06/14 22:08:07 UTC

svn commit: r547385 - /maven/archiva/trunk/archiva-base/archiva-xml-tools/src/main/java/org/apache/maven/archiva/xml/XMLWriter.java

Author: jmcconnell
Date: Thu Jun 14 13:08:06 2007
New Revision: 547385

URL: http://svn.apache.org/viewvc?view=rev&rev=547385
Log:
flush the outputwriter so its all cleaned up

Modified:
    maven/archiva/trunk/archiva-base/archiva-xml-tools/src/main/java/org/apache/maven/archiva/xml/XMLWriter.java

Modified: maven/archiva/trunk/archiva-base/archiva-xml-tools/src/main/java/org/apache/maven/archiva/xml/XMLWriter.java
URL: http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-base/archiva-xml-tools/src/main/java/org/apache/maven/archiva/xml/XMLWriter.java?view=diff&rev=547385&r1=547384&r2=547385
==============================================================================
--- maven/archiva/trunk/archiva-base/archiva-xml-tools/src/main/java/org/apache/maven/archiva/xml/XMLWriter.java (original)
+++ maven/archiva/trunk/archiva-base/archiva-xml-tools/src/main/java/org/apache/maven/archiva/xml/XMLWriter.java Thu Jun 14 13:08:06 2007
@@ -41,6 +41,7 @@
             OutputFormat outputFormat = OutputFormat.createPrettyPrint();
             org.dom4j.io.XMLWriter xmlwriter = new org.dom4j.io.XMLWriter( writer, outputFormat );
             xmlwriter.write( doc );
+            xmlwriter.flush();
         }
         catch ( IOException e )
         {



Re: svn commit: r547385 - /maven/archiva/trunk/archiva-base/archiva-xml-tools/src/main/java/org/apache/maven/archiva/xml/XMLWriter.java

Posted by Brett Porter <br...@apache.org>.
Isn't the problem instead that there's no finally block closing the  
writer?

On 15/06/2007, at 6:08 AM, jmcconnell@apache.org wrote:

> Author: jmcconnell
> Date: Thu Jun 14 13:08:06 2007
> New Revision: 547385
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=547385
> Log:
> flush the outputwriter so its all cleaned up
>
> Modified:
>     maven/archiva/trunk/archiva-base/archiva-xml-tools/src/main/ 
> java/org/apache/maven/archiva/xml/XMLWriter.java
>
> Modified: maven/archiva/trunk/archiva-base/archiva-xml-tools/src/ 
> main/java/org/apache/maven/archiva/xml/XMLWriter.java
> URL: http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-base/ 
> archiva-xml-tools/src/main/java/org/apache/maven/archiva/xml/ 
> XMLWriter.java?view=diff&rev=547385&r1=547384&r2=547385
> ====================================================================== 
> ========
> --- maven/archiva/trunk/archiva-base/archiva-xml-tools/src/main/ 
> java/org/apache/maven/archiva/xml/XMLWriter.java (original)
> +++ maven/archiva/trunk/archiva-base/archiva-xml-tools/src/main/ 
> java/org/apache/maven/archiva/xml/XMLWriter.java Thu Jun 14  
> 13:08:06 2007
> @@ -41,6 +41,7 @@
>              OutputFormat outputFormat =  
> OutputFormat.createPrettyPrint();
>              org.dom4j.io.XMLWriter xmlwriter = new  
> org.dom4j.io.XMLWriter( writer, outputFormat );
>              xmlwriter.write( doc );
> +            xmlwriter.flush();
>          }
>          catch ( IOException e )
>          {
>