[superset] branch master updated: chore: postpone timerange endpoint removal (#19513)

[vi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

villebro pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 1eef923b31 chore: postpone timerange endpoint removal (#19513)
1eef923b31 is described below

commit 1eef923b31005eaf13e4b068a939d0fb27716c90
Author: Ville Brofeldt <33...@users.noreply.github.com>
AuthorDate: Tue Apr 5 10:10:29 2022 +0300

    chore: postpone timerange endpoint removal (#19513)
---
 .../ab9a9d86e695_deprecate_time_range_endpoints.py | 27 +---------------------
 ...0249074e4_deprecate_time_range_endpoints_v2.py} | 12 +++++-----
 2 files changed, 7 insertions(+), 32 deletions(-)

diff --git a/superset/migrations/versions/ab9a9d86e695_deprecate_time_range_endpoints.py b/superset/migrations/versions/ab9a9d86e695_deprecate_time_range_endpoints.py
index 2bd6599614..148804d258 100644
--- a/superset/migrations/versions/ab9a9d86e695_deprecate_time_range_endpoints.py
+++ b/superset/migrations/versions/ab9a9d86e695_deprecate_time_range_endpoints.py
@@ -21,38 +21,13 @@ Revises: b5a422d8e252
 Create Date: 2022-02-25 08:06:14.835094
 
 """
-import json
-
-from alembic import op
-from sqlalchemy import Column, Integer, Text
-from sqlalchemy.ext.declarative import declarative_base
-
-from superset import db
-
 # revision identifiers, used by Alembic.
 revision = "ab9a9d86e695"
 down_revision = "b5a422d8e252"
 
-Base = declarative_base()
-
-
-class Slice(Base):
-    __tablename__ = "slices"
-    id = Column(Integer, primary_key=True)
-    params = Column(Text)
-
 
 def upgrade():
-    bind = op.get_bind()
-    session = db.Session(bind=bind)
-
-    for slc in session.query(Slice).filter(Slice.params.like("%time_range_endpoints%")):
-        params = json.loads(slc.params)
-        params.pop("time_range_endpoints", None)
-        slc.params = json.dumps(params)
-
-    session.commit()
-    session.close()
+    pass
 
 
 def downgrade():
diff --git a/superset/migrations/versions/ab9a9d86e695_deprecate_time_range_endpoints.py b/superset/migrations/versions/b0d0249074e4_deprecate_time_range_endpoints_v2.py
similarity index 89%
copy from superset/migrations/versions/ab9a9d86e695_deprecate_time_range_endpoints.py
copy to superset/migrations/versions/b0d0249074e4_deprecate_time_range_endpoints_v2.py
index 2bd6599614..90ee62d3f7 100644
--- a/superset/migrations/versions/ab9a9d86e695_deprecate_time_range_endpoints.py
+++ b/superset/migrations/versions/b0d0249074e4_deprecate_time_range_endpoints_v2.py
@@ -14,11 +14,11 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-"""deprecate time_range_endpoints
+"""deprecate time_range_endpoints v2
 
-Revision ID: ab9a9d86e695
-Revises: b5a422d8e252
-Create Date: 2022-02-25 08:06:14.835094
+Revision ID: b0d0249074e4
+Revises: 2ed890b36b94
+Create Date: 2022-04-04 15:04:05.606340
 
 """
 import json
@@ -30,8 +30,8 @@ from sqlalchemy.ext.declarative import declarative_base
 from superset import db
 
 # revision identifiers, used by Alembic.
-revision = "ab9a9d86e695"
-down_revision = "b5a422d8e252"
+revision = "b0d0249074e4"
+down_revision = "2ed890b36b94"
 
 Base = declarative_base()