You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/06/26 20:02:48 UTC

[GitHub] rob05c commented on a change in pull request #2305: Add TO Go cdns/health

rob05c commented on a change in pull request #2305: Add TO Go cdns/health
URL: https://github.com/apache/trafficcontrol/pull/2305#discussion_r198278695
 
 

 ##########
 File path: lib/go-tc/enum.go
 ##########
 @@ -53,6 +53,8 @@ type DeliveryServiceName string
 // CacheType is the type (or tier) of a CDN cache.
 type CacheType string
 
+const MonitorTypeName = "RASCAL"
 
 Review comment:
   I think it should definitely be a config, once we've moved everything to Go. But right now, it's still hard-coded all over Perl. 
   
   I don't think we should make a config yet, which would make people think they could change it, when it'd still break to be anything but "RASCAL".
   
   But definitely +100 when it's all Go, and we can set one variable. I've wanted to change our db "RASCAL" type to something like "monitor" for ages.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services