You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Julian Reschke (Created) (JIRA)" <ji...@apache.org> on 2011/10/19 16:06:10 UTC
[jira] [Created] (JCR-3121)
InternalVersionManagerBase.getVersionHistoryOfNode should throws
InconsistentVersioningState when it encounters a runtime exception
InternalVersionManagerBase.getVersionHistoryOfNode should throws InconsistentVersioningState when it encounters a runtime exception
-----------------------------------------------------------------------------------------------------------------------------------
Key: JCR-3121
URL: https://issues.apache.org/jira/browse/JCR-3121
Project: Jackrabbit Content Repository
Issue Type: Bug
Components: jackrabbit-core, versioning
Reporter: Julian Reschke
Assignee: Julian Reschke
Fix For: 2.2.10, 2.3.2
When the versioning persistence is inconsistent (such as broken hierarchy in intermediary nodes), various calls in getVersionHistoryOfNode might fail with runtime exceptions.
Catch those and report InconsistentVersioningState instead, supplying the node id of the version history; this will enable the versioning fixup to move away the version history (see JCR-3115).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JCR-3121)
InternalVersionManagerBase.getVersionHistoryOfNode should throw
InconsistentVersioningState when it encounters a runtime exception
Posted by "Julian Reschke (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke resolved JCR-3121.
---------------------------------
Resolution: Won't Fix
Not needed anymore due to changes done with respect to JCR-3115.
> InternalVersionManagerBase.getVersionHistoryOfNode should throw InconsistentVersioningState when it encounters a runtime exception
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: JCR-3121
> URL: https://issues.apache.org/jira/browse/JCR-3121
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core, versioning
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Fix For: 2.2.10
>
> Attachments: JCR-3121.patch
>
>
> When the versioning persistence is inconsistent (such as broken hierarchy in intermediary nodes), various calls in getVersionHistoryOfNode might fail with runtime exceptions.
> Catch those and report InconsistentVersioningState instead, supplying the node id of the version history; this will enable the versioning fixup to move away the version history (see JCR-3115).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3121)
InternalVersionManagerBase.getVersionHistoryOfNode should throws
InconsistentVersioningState when it encounters a runtime exception
Posted by "Julian Reschke (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated JCR-3121:
--------------------------------
Attachment: JCR-3121.patch
Proposed patch.
Catching runtime exceptions is a bit unorthodox, but it avoids adding lots of null checks deeper in the call stacks. Recall that these checks aren't strictly needed unless the persistence is inconsistent.
> InternalVersionManagerBase.getVersionHistoryOfNode should throws InconsistentVersioningState when it encounters a runtime exception
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: JCR-3121
> URL: https://issues.apache.org/jira/browse/JCR-3121
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core, versioning
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Fix For: 2.2.10, 2.3.2
>
> Attachments: JCR-3121.patch
>
>
> When the versioning persistence is inconsistent (such as broken hierarchy in intermediary nodes), various calls in getVersionHistoryOfNode might fail with runtime exceptions.
> Catch those and report InconsistentVersioningState instead, supplying the node id of the version history; this will enable the versioning fixup to move away the version history (see JCR-3115).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3121)
InternalVersionManagerBase.getVersionHistoryOfNode should throw
InconsistentVersioningState when it encounters a runtime exception
Posted by "Julian Reschke (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140253#comment-13140253 ]
Julian Reschke commented on JCR-3121:
-------------------------------------
Rather than doing this we have instead changed the checker code to obtain the version history node ID as early as possible, which means that there are less cases we need to piggy-back the node ID to the exception (see JCR-3115).
> InternalVersionManagerBase.getVersionHistoryOfNode should throw InconsistentVersioningState when it encounters a runtime exception
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: JCR-3121
> URL: https://issues.apache.org/jira/browse/JCR-3121
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core, versioning
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Fix For: 2.2.10
>
> Attachments: JCR-3121.patch
>
>
> When the versioning persistence is inconsistent (such as broken hierarchy in intermediary nodes), various calls in getVersionHistoryOfNode might fail with runtime exceptions.
> Catch those and report InconsistentVersioningState instead, supplying the node id of the version history; this will enable the versioning fixup to move away the version history (see JCR-3115).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3121)
InternalVersionManagerBase.getVersionHistoryOfNode should throw
InconsistentVersioningState when it encounters a runtime exception
Posted by "Julian Reschke (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131500#comment-13131500 ]
Julian Reschke commented on JCR-3121:
-------------------------------------
Revised plan: modify VersionManager so that we can get the history node id upfront; this will enable the versioning fixup to do the "right" thing without having too touch even more pieces of code.
> InternalVersionManagerBase.getVersionHistoryOfNode should throw InconsistentVersioningState when it encounters a runtime exception
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: JCR-3121
> URL: https://issues.apache.org/jira/browse/JCR-3121
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core, versioning
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Fix For: 2.2.10, 2.3.2
>
> Attachments: JCR-3121.patch
>
>
> When the versioning persistence is inconsistent (such as broken hierarchy in intermediary nodes), various calls in getVersionHistoryOfNode might fail with runtime exceptions.
> Catch those and report InconsistentVersioningState instead, supplying the node id of the version history; this will enable the versioning fixup to move away the version history (see JCR-3115).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3121)
InternalVersionManagerBase.getVersionHistoryOfNode should throw
InconsistentVersioningState when it encounters a runtime exception
Posted by "Jukka Zitting (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-3121:
-------------------------------
Fix Version/s: (was: 2.3.2)
> InternalVersionManagerBase.getVersionHistoryOfNode should throw InconsistentVersioningState when it encounters a runtime exception
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: JCR-3121
> URL: https://issues.apache.org/jira/browse/JCR-3121
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core, versioning
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Fix For: 2.2.10
>
> Attachments: JCR-3121.patch
>
>
> When the versioning persistence is inconsistent (such as broken hierarchy in intermediary nodes), various calls in getVersionHistoryOfNode might fail with runtime exceptions.
> Catch those and report InconsistentVersioningState instead, supplying the node id of the version history; this will enable the versioning fixup to move away the version history (see JCR-3115).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3121)
InternalVersionManagerBase.getVersionHistoryOfNode should throw
InconsistentVersioningState when it encounters a runtime exception
Posted by "Julian Reschke (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated JCR-3121:
--------------------------------
Summary: InternalVersionManagerBase.getVersionHistoryOfNode should throw InconsistentVersioningState when it encounters a runtime exception (was: InternalVersionManagerBase.getVersionHistoryOfNode should throws InconsistentVersioningState when it encounters a runtime exception)
> InternalVersionManagerBase.getVersionHistoryOfNode should throw InconsistentVersioningState when it encounters a runtime exception
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: JCR-3121
> URL: https://issues.apache.org/jira/browse/JCR-3121
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core, versioning
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Fix For: 2.2.10, 2.3.2
>
> Attachments: JCR-3121.patch
>
>
> When the versioning persistence is inconsistent (such as broken hierarchy in intermediary nodes), various calls in getVersionHistoryOfNode might fail with runtime exceptions.
> Catch those and report InconsistentVersioningState instead, supplying the node id of the version history; this will enable the versioning fixup to move away the version history (see JCR-3115).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3121)
InternalVersionManagerBase.getVersionHistoryOfNode should throw
InconsistentVersioningState when it encounters a runtime exception
Posted by "Jukka Zitting (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-3121:
-------------------------------
Fix Version/s: (was: 2.2.10)
> InternalVersionManagerBase.getVersionHistoryOfNode should throw InconsistentVersioningState when it encounters a runtime exception
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: JCR-3121
> URL: https://issues.apache.org/jira/browse/JCR-3121
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core, versioning
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Attachments: JCR-3121.patch
>
>
> When the versioning persistence is inconsistent (such as broken hierarchy in intermediary nodes), various calls in getVersionHistoryOfNode might fail with runtime exceptions.
> Catch those and report InconsistentVersioningState instead, supplying the node id of the version history; this will enable the versioning fixup to move away the version history (see JCR-3115).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira