[GitHub] [nifi] mattyb149 commented on a change in pull request #3341: NIFI-6082: Added DatabaseRecordLookupService, refactored common DB utils

[GitBox <gi...@apache.org>]

mattyb149 commented on a change in pull request #3341: NIFI-6082: Added DatabaseRecordLookupService, refactored common DB utils
URL: https://github.com/apache/nifi/pull/3341#discussion_r264000801
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/util/TestJdbcHugeStream.java
 ##########
 @@ -30,14 +38,7 @@
 import java.sql.Statement;
 import java.util.Random;
 
-import org.apache.avro.file.DataFileStream;
-import org.apache.avro.generic.GenericDatumReader;
-import org.apache.avro.generic.GenericRecord;
-import org.apache.avro.io.DatumReader;
-import org.junit.BeforeClass;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.TemporaryFolder;
+import static org.junit.Assert.assertEquals;
 
 Review comment:
   I tried to remove everything, but I think some other tests in standard-processors use the method(s) here to load up a test DB. I remember needing some stuff in both places, and didn't want to try to refactor the tests vs the utils. I can take a closer look if you like

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services