[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #196: retry mqtt stream test that fails a lot

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on PR #196:
URL: https://github.com/apache/incubator-pekko-connectors/pull/196#issuecomment-1686067972

   I didn't have a look at the PR because to me it seemed like it was overengineered and that maybe the best solution would be to use something like scalatest's https://www.scalatest.org/scaladoc/3.0.8/org/scalatest/Retries.html ?
   
   If we are not solving the core issue behind way the test is flaky I have a preference for using techniques such as ScalaTest 'Retries`, or put differently I have an aversion to modifying a test a lot unless its actually solving the core problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org