You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/15 20:52:07 UTC
[GitHub] [arrow] nealrichardson opened a new pull request #12436: ARROW-15690: [Dev] Update GitHub Actions workflows that hardcode master as default
nealrichardson opened a new pull request #12436:
URL: https://github.com/apache/arrow/pull/12436
Included a few other master-related cleanups I saw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12436: ARROW-15690: [Dev] Update GitHub Actions workflows that hardcode master as default
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12436:
URL: https://github.com/apache/arrow/pull/12436#issuecomment-1042307000
Benchmark runs are scheduled for baseline = e4e866fe6d222900262aed77274f46713bd89e9f and contender = ee9354db75d24914f19ec6bbac43093026f66b8e. ee9354db75d24914f19ec6bbac43093026f66b8e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6e5bf4b8c99b45e59385cf0fc1d0fe2d...c45f1cc43fe644d7b811bf211018c872/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fac73aa27c154f44a33d971a8732a5e3...cc1b392d7b824e3f98d9938207fcc4c4/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/37bc74d550dd44a4afb2e994f87426cc...f0b39a58816e46eca6a9d69da4c15fff/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9eb0f6f19b5e48fc93158930fd8f67a3...b41762f36e53444a9033796a429e6716/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12436: ARROW-15690: [Dev] Update GitHub Actions workflows that hardcode master as default
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12436:
URL: https://github.com/apache/arrow/pull/12436#discussion_r807793931
##########
File path: ci/scripts/install_kartothek.sh
##########
@@ -28,9 +28,7 @@ karthothek=$1
target=$2
git clone --recurse-submodules https://github.com/JDASoftwareGroup/kartothek "${target}"
-if [ "${kartothek}" = "master" ]; then
Review comment:
Did you check that no existing CI job was passing "master" to this script?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #12436: ARROW-15690: [Dev] Update GitHub Actions workflows that hardcode master as default
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #12436:
URL: https://github.com/apache/arrow/pull/12436#discussion_r807304850
##########
File path: .github/workflows/dev_pr.yml
##########
@@ -21,7 +21,7 @@ on:
# TODO: Enable this when eps1lon/actions-label-merge-conflict is available.
# push:
# branches:
- # - master
+ # - [master, main]
Review comment:
```suggestion
# - master
# - main
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12436: ARROW-15690: [Dev] Update GitHub Actions workflows that hardcode master as default
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12436:
URL: https://github.com/apache/arrow/pull/12436#issuecomment-1042307000
Benchmark runs are scheduled for baseline = e4e866fe6d222900262aed77274f46713bd89e9f and contender = ee9354db75d24914f19ec6bbac43093026f66b8e. ee9354db75d24914f19ec6bbac43093026f66b8e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6e5bf4b8c99b45e59385cf0fc1d0fe2d...c45f1cc43fe644d7b811bf211018c872/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fac73aa27c154f44a33d971a8732a5e3...cc1b392d7b824e3f98d9938207fcc4c4/)
[Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/37bc74d550dd44a4afb2e994f87426cc...f0b39a58816e46eca6a9d69da4c15fff/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9eb0f6f19b5e48fc93158930fd8f67a3...b41762f36e53444a9033796a429e6716/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12436: ARROW-15690: [Dev] Update GitHub Actions workflows that hardcode master as default
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12436:
URL: https://github.com/apache/arrow/pull/12436#discussion_r807794812
##########
File path: ci/scripts/install_kartothek.sh
##########
@@ -28,9 +28,7 @@ karthothek=$1
target=$2
git clone --recurse-submodules https://github.com/JDASoftwareGroup/kartothek "${target}"
-if [ "${kartothek}" = "master" ]; then
Review comment:
I see, it's simply redundant with the `else` branch below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #12436: ARROW-15690: [Dev] Update GitHub Actions workflows that hardcode master as default
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #12436:
URL: https://github.com/apache/arrow/pull/12436#discussion_r807990494
##########
File path: ci/scripts/install_kartothek.sh
##########
@@ -28,9 +28,7 @@ karthothek=$1
target=$2
git clone --recurse-submodules https://github.com/JDASoftwareGroup/kartothek "${target}"
-if [ "${kartothek}" = "master" ]; then
Review comment:
Correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12436: ARROW-15690: [Dev] Update GitHub Actions workflows that hardcode master as default
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12436:
URL: https://github.com/apache/arrow/pull/12436#discussion_r807794081
##########
File path: ci/scripts/install_turbodbc.sh
##########
@@ -28,9 +28,7 @@ turbodbc=$1
target=$2
git clone --recurse-submodules https://github.com/blue-yonder/turbodbc "${target}"
-if [ "${turbodbc}" = "master" ]; then
Review comment:
Same question here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #12436: ARROW-15690: [Dev] Update GitHub Actions workflows that hardcode master as default
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #12436:
URL: https://github.com/apache/arrow/pull/12436#issuecomment-1040807014
I'll back out the R windows job changes for now, they're unrelated (they're about the r-lib/actions tag, not our master branch). It looks like pacman isn't on the path in the v2 workflows (https://github.com/r-lib/actions/compare/master...v2-branch#diff-3e2a1a7f497c1884dc161d6e07fdc58e4853eb91bf13034122e3814b501df0d5L382), I'll follow up with that upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12436: ARROW-15690: [Dev] Update GitHub Actions workflows that hardcode master as default
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12436:
URL: https://github.com/apache/arrow/pull/12436#issuecomment-1042307000
Benchmark runs are scheduled for baseline = e4e866fe6d222900262aed77274f46713bd89e9f and contender = ee9354db75d24914f19ec6bbac43093026f66b8e. ee9354db75d24914f19ec6bbac43093026f66b8e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6e5bf4b8c99b45e59385cf0fc1d0fe2d...c45f1cc43fe644d7b811bf211018c872/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fac73aa27c154f44a33d971a8732a5e3...cc1b392d7b824e3f98d9938207fcc4c4/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/37bc74d550dd44a4afb2e994f87426cc...f0b39a58816e46eca6a9d69da4c15fff/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9eb0f6f19b5e48fc93158930fd8f67a3...b41762f36e53444a9033796a429e6716/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #12436: ARROW-15690: [Dev] Update GitHub Actions workflows that hardcode master as default
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #12436:
URL: https://github.com/apache/arrow/pull/12436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #12436: ARROW-15690: [Dev] Update GitHub Actions workflows that hardcode master as default
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #12436:
URL: https://github.com/apache/arrow/pull/12436#discussion_r808054773
##########
File path: ci/scripts/install_kartothek.sh
##########
@@ -28,9 +28,7 @@ karthothek=$1
target=$2
git clone --recurse-submodules https://github.com/JDASoftwareGroup/kartothek "${target}"
-if [ "${kartothek}" = "master" ]; then
Review comment:
Yes, we can safely remove this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12436: ARROW-15690: [Dev] Update GitHub Actions workflows that hardcode master as default
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12436:
URL: https://github.com/apache/arrow/pull/12436#issuecomment-1040781110
https://issues.apache.org/jira/browse/ARROW-15690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #12436: ARROW-15690: [Dev] Update GitHub Actions workflows that hardcode master as default
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #12436:
URL: https://github.com/apache/arrow/pull/12436#issuecomment-1041872011
> @nealrichardson it looks good to me, but the R builds are failing.
@kszucs I fixed the issue upstream, builds passed this time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #12436: ARROW-15690: [Dev] Update GitHub Actions workflows that hardcode master as default
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #12436:
URL: https://github.com/apache/arrow/pull/12436#issuecomment-1041560535
@nealrichardson it looks good to me, but the R builds are failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org