You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "tkobayas (via GitHub)" <gi...@apache.org> on 2024/02/22 06:01:43 UTC
[PR] [incubator-kie-drools#5728] Update PR template [incubator-kie-drools]
tkobayas opened a new pull request, #5729:
URL: https://github.com/apache/incubator-kie-drools/pull/5729
**Issue**:
* https://github.com/apache/incubator-kie-drools/issues/5728
1. Remove old kiegroup specific guidance
-> Removed Jenkins command comment which is no longer working.
2. Suggest to use github issue rather than JIRA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools#5728] Update PR template [incubator-kie-drools]
Posted by "baldimir (via GitHub)" <gi...@apache.org>.
baldimir commented on code in PR #5729:
URL: https://github.com/apache/incubator-kie-drools/pull/5729#discussion_r1500531012
##########
.github/pull_request_template.md:
##########
@@ -1,16 +1,16 @@
**Thank you for submitting this pull request**
-**NOTE!:** Double check the target branch for this PR.
+**NOTE!:** Double-check the target branch for this PR.
The default is `main` so it will target Drools 8 / Kogito.
-If this PR is not strictly related to drools and kogito project in `drools.git`, it should probably target `7.x`as a branch
+If this PR is targeted to `7.x`, this should be sent to `kiegroup/drools` repository, instead of `apache/incubator-kie-drools` repository.
Review Comment:
I think we could skip/delete this, as I am not sure if it is ok to have these kind of recommendations to forks, in an Apache project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools#5728] Update PR template [incubator-kie-drools]
Posted by "baldimir (via GitHub)" <gi...@apache.org>.
baldimir merged PR #5729:
URL: https://github.com/apache/incubator-kie-drools/pull/5729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools#5728] Update PR template [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on PR #5729:
URL: https://github.com/apache/incubator-kie-drools/pull/5729#issuecomment-1958762899
@mariofusco @rgdoliveira @baldimir Please review, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools#5728] Update PR template [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #5729:
URL: https://github.com/apache/incubator-kie-drools/pull/5729#discussion_r1502006310
##########
.github/pull_request_template.md:
##########
@@ -1,16 +1,16 @@
**Thank you for submitting this pull request**
-**NOTE!:** Double check the target branch for this PR.
+**NOTE!:** Double-check the target branch for this PR.
The default is `main` so it will target Drools 8 / Kogito.
-If this PR is not strictly related to drools and kogito project in `drools.git`, it should probably target `7.x`as a branch
+If this PR is targeted to `7.x`, this should be sent to `kiegroup/drools` repository, instead of `apache/incubator-kie-drools` repository.
Review Comment:
@baldimir Thanks, agreed. I removed the mention to kiegroup repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org