You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by go...@apache.org on 2011/06/12 23:54:28 UTC
svn commit: r1134992 - in /maven/scm/trunk/maven-scm-providers:
maven-scm-provider-bazaar/src/main/java/org/apache/maven/scm/provider/bazaar/
maven-scm-provider-bazaar/src/main/java/org/apache/maven/scm/provider/bazaar/command/
maven-scm-provider-clear...
Author: godin
Date: Sun Jun 12 21:54:27 2011
New Revision: 1134992
URL: http://svn.apache.org/viewvc?rev=1134992&view=rev
Log:
Improve quality according to Sonar report - Hide Utility Class Constructor
Modified:
maven/scm/trunk/maven-scm-providers/maven-scm-provider-bazaar/src/main/java/org/apache/maven/scm/provider/bazaar/BazaarUtils.java
maven/scm/trunk/maven-scm-providers/maven-scm-provider-bazaar/src/main/java/org/apache/maven/scm/provider/bazaar/command/BazaarConstants.java
maven/scm/trunk/maven-scm-providers/maven-scm-provider-clearcase/src/main/java/org/apache/maven/scm/provider/clearcase/util/ClearCaseUtil.java
maven/scm/trunk/maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/HgUtils.java
maven/scm/trunk/maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/command/HgCommandConstants.java
maven/scm/trunk/maven-scm-providers/maven-scm-provider-starteam/src/main/java/org/apache/maven/scm/provider/starteam/command/StarteamCommandLineUtils.java
maven/scm/trunk/maven-scm-providers/maven-scm-provider-starteam/src/main/java/org/apache/maven/scm/provider/starteam/util/StarteamUtil.java
maven/scm/trunk/maven-scm-providers/maven-scm-provider-synergy/src/main/java/org/apache/maven/scm/provider/synergy/util/SynergyUtil.java
maven/scm/trunk/maven-scm-providers/maven-scm-provider-vss/src/main/java/org/apache/maven/scm/provider/vss/commands/VssCommandLineUtils.java
maven/scm/trunk/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/GitCommandLineUtils.java
maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/src/main/java/org/apache/maven/scm/provider/svn/SvnCommandUtils.java
maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/src/main/java/org/apache/maven/scm/provider/svn/SvnTagBranchUtils.java
maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/main/java/org/apache/maven/scm/provider/svn/svnexe/command/SvnCommandLineUtils.java
Modified: maven/scm/trunk/maven-scm-providers/maven-scm-provider-bazaar/src/main/java/org/apache/maven/scm/provider/bazaar/BazaarUtils.java
URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-provider-bazaar/src/main/java/org/apache/maven/scm/provider/bazaar/BazaarUtils.java?rev=1134992&r1=1134991&r2=1134992&view=diff
==============================================================================
--- maven/scm/trunk/maven-scm-providers/maven-scm-provider-bazaar/src/main/java/org/apache/maven/scm/provider/bazaar/BazaarUtils.java (original)
+++ maven/scm/trunk/maven-scm-providers/maven-scm-provider-bazaar/src/main/java/org/apache/maven/scm/provider/bazaar/BazaarUtils.java Sun Jun 12 21:54:27 2011
@@ -43,8 +43,13 @@ import java.util.Map;
* @author <a href="mailto:torbjorn@smorgrav.org">Torbj�rn Eikli Sm�rgrav</a>
* @version $Id$
*/
-public class BazaarUtils
+public final class BazaarUtils
{
+
+ private BazaarUtils()
+ {
+ }
+
/**
* Map between command and its valid exit codes
*/
Modified: maven/scm/trunk/maven-scm-providers/maven-scm-provider-bazaar/src/main/java/org/apache/maven/scm/provider/bazaar/command/BazaarConstants.java
URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-provider-bazaar/src/main/java/org/apache/maven/scm/provider/bazaar/command/BazaarConstants.java?rev=1134992&r1=1134991&r2=1134992&view=diff
==============================================================================
--- maven/scm/trunk/maven-scm-providers/maven-scm-provider-bazaar/src/main/java/org/apache/maven/scm/provider/bazaar/command/BazaarConstants.java (original)
+++ maven/scm/trunk/maven-scm-providers/maven-scm-provider-bazaar/src/main/java/org/apache/maven/scm/provider/bazaar/command/BazaarConstants.java Sun Jun 12 21:54:27 2011
@@ -31,6 +31,10 @@ package org.apache.maven.scm.provider.ba
*/
public class BazaarConstants
{
+ private BazaarConstants()
+ {
+ }
+
/**
* Executable for Bazaar
*/
@@ -100,7 +104,7 @@ public class BazaarConstants
* List directory contents, bazaar style.
*/
public static final String LS_CMD = "ls";
-
+
/**
* Show inventory of the current working copy or a revision
*/
@@ -120,7 +124,7 @@ public class BazaarConstants
* Option to enable recursing into subdirectories.
*/
public static final String RECURSIVE_OPTION = "--recursive";
-
+
public static final String VERSION = "version";
public static final String CHECK = "check";
Modified: maven/scm/trunk/maven-scm-providers/maven-scm-provider-clearcase/src/main/java/org/apache/maven/scm/provider/clearcase/util/ClearCaseUtil.java
URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-provider-clearcase/src/main/java/org/apache/maven/scm/provider/clearcase/util/ClearCaseUtil.java?rev=1134992&r1=1134991&r2=1134992&view=diff
==============================================================================
--- maven/scm/trunk/maven-scm-providers/maven-scm-provider-clearcase/src/main/java/org/apache/maven/scm/provider/clearcase/util/ClearCaseUtil.java (original)
+++ maven/scm/trunk/maven-scm-providers/maven-scm-provider-clearcase/src/main/java/org/apache/maven/scm/provider/clearcase/util/ClearCaseUtil.java Sun Jun 12 21:54:27 2011
@@ -33,8 +33,9 @@ import org.codehaus.plexus.util.xml.pull
* @author <a href="mailto:evenisse@apache.org">Emmanuel Venisse</a>
* @version $Id$
*/
-public class ClearCaseUtil
+public final class ClearCaseUtil
{
+
protected static final String CLEARCASE_SETTINGS_FILENAME = "clearcase-settings.xml";
public static final File DEFAULT_SETTINGS_DIRECTORY = new File( System.getProperty( "user.home" ), ".scm" );
@@ -46,7 +47,7 @@ public class ClearCaseUtil
private static final ResourceBundle RESOURCE_BUNDLE = ResourceBundle.getBundle( RESOURCE_FILENAME );
private static Settings settings;
-
+
private ClearCaseUtil()
{
}
Modified: maven/scm/trunk/maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/HgUtils.java
URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/HgUtils.java?rev=1134992&r1=1134991&r2=1134992&view=diff
==============================================================================
--- maven/scm/trunk/maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/HgUtils.java (original)
+++ maven/scm/trunk/maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/HgUtils.java Sun Jun 12 21:54:27 2011
@@ -46,8 +46,12 @@ import java.util.Map;
* @author <a href="mailto:thurner.rupert@ymono.net">thurner rupert</a>
* @version $Id$
*/
-public class HgUtils
+public final class HgUtils
{
+
+ private HgUtils() {
+ }
+
/**
* Map between command and its valid exit codes
*/
Modified: maven/scm/trunk/maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/command/HgCommandConstants.java
URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/command/HgCommandConstants.java?rev=1134992&r1=1134991&r2=1134992&view=diff
==============================================================================
--- maven/scm/trunk/maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/command/HgCommandConstants.java (original)
+++ maven/scm/trunk/maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/command/HgCommandConstants.java Sun Jun 12 21:54:27 2011
@@ -29,8 +29,13 @@ package org.apache.maven.scm.provider.hg
* @author <a href="mailto:thurner.rupert@ymono.net">thurner rupert</a>
* @version $Id$
*/
-public class HgCommandConstants
+public final class HgCommandConstants
{
+
+ private HgCommandConstants()
+ {
+ }
+
/**
* Executable for Hg
*/
Modified: maven/scm/trunk/maven-scm-providers/maven-scm-provider-starteam/src/main/java/org/apache/maven/scm/provider/starteam/command/StarteamCommandLineUtils.java
URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-provider-starteam/src/main/java/org/apache/maven/scm/provider/starteam/command/StarteamCommandLineUtils.java?rev=1134992&r1=1134991&r2=1134992&view=diff
==============================================================================
--- maven/scm/trunk/maven-scm-providers/maven-scm-provider-starteam/src/main/java/org/apache/maven/scm/provider/starteam/command/StarteamCommandLineUtils.java (original)
+++ maven/scm/trunk/maven-scm-providers/maven-scm-provider-starteam/src/main/java/org/apache/maven/scm/provider/starteam/command/StarteamCommandLineUtils.java Sun Jun 12 21:54:27 2011
@@ -40,8 +40,13 @@ import java.util.List;
* @author Dan T. Tran
* @version $Id$
*/
-public class StarteamCommandLineUtils
+public final class StarteamCommandLineUtils
{
+
+ private StarteamCommandLineUtils()
+ {
+ }
+
private static Settings settings = StarteamUtil.getSettings();
public static Commandline createStarteamBaseCommandLine( String action, StarteamScmProviderRepository repo )
Modified: maven/scm/trunk/maven-scm-providers/maven-scm-provider-starteam/src/main/java/org/apache/maven/scm/provider/starteam/util/StarteamUtil.java
URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-provider-starteam/src/main/java/org/apache/maven/scm/provider/starteam/util/StarteamUtil.java?rev=1134992&r1=1134991&r2=1134992&view=diff
==============================================================================
--- maven/scm/trunk/maven-scm-providers/maven-scm-provider-starteam/src/main/java/org/apache/maven/scm/provider/starteam/util/StarteamUtil.java (original)
+++ maven/scm/trunk/maven-scm-providers/maven-scm-provider-starteam/src/main/java/org/apache/maven/scm/provider/starteam/util/StarteamUtil.java Sun Jun 12 21:54:27 2011
@@ -32,16 +32,17 @@ import java.io.IOException;
* @author <a href="mailto:dantran@apache.org">Dan T. Tran</a>
* @version $Id: $
*/
-public class StarteamUtil
+public final class StarteamUtil
{
- protected static final String STARTEAM_SETTINGS_FILENAME = "starteam-settings.xml";
+
+ protected static final String STARTEAM_SETTINGS_FILENAME = "starteam-settings.xml";
public static final File DEFAULT_SETTINGS_DIRECTORY = new File( System.getProperty( "user.home" ), ".scm" );
private static File settingsDirectory = DEFAULT_SETTINGS_DIRECTORY;
-
+
private static Settings settings;
-
+
private StarteamUtil()
{
}
Modified: maven/scm/trunk/maven-scm-providers/maven-scm-provider-synergy/src/main/java/org/apache/maven/scm/provider/synergy/util/SynergyUtil.java
URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-provider-synergy/src/main/java/org/apache/maven/scm/provider/synergy/util/SynergyUtil.java?rev=1134992&r1=1134991&r2=1134992&view=diff
==============================================================================
--- maven/scm/trunk/maven-scm-providers/maven-scm-provider-synergy/src/main/java/org/apache/maven/scm/provider/synergy/util/SynergyUtil.java (original)
+++ maven/scm/trunk/maven-scm-providers/maven-scm-provider-synergy/src/main/java/org/apache/maven/scm/provider/synergy/util/SynergyUtil.java Sun Jun 12 21:54:27 2011
@@ -51,9 +51,13 @@ import org.codehaus.plexus.util.cli.Stre
* @author Olivier Lamy
* @version $Id$
*/
-public class SynergyUtil
+public final class SynergyUtil
{
+ private SynergyUtil()
+ {
+ }
+
/**
* Separator used with formatted result
*/
Modified: maven/scm/trunk/maven-scm-providers/maven-scm-provider-vss/src/main/java/org/apache/maven/scm/provider/vss/commands/VssCommandLineUtils.java
URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-provider-vss/src/main/java/org/apache/maven/scm/provider/vss/commands/VssCommandLineUtils.java?rev=1134992&r1=1134991&r2=1134992&view=diff
==============================================================================
--- maven/scm/trunk/maven-scm-providers/maven-scm-provider-vss/src/main/java/org/apache/maven/scm/provider/vss/commands/VssCommandLineUtils.java (original)
+++ maven/scm/trunk/maven-scm-providers/maven-scm-provider-vss/src/main/java/org/apache/maven/scm/provider/vss/commands/VssCommandLineUtils.java Sun Jun 12 21:54:27 2011
@@ -42,11 +42,15 @@ import java.util.Iterator;
* @author <a href="mailto:triek@thrx.de">Thorsten Riek</a>
* @version $Id$
*/
-public class VssCommandLineUtils
+public final class VssCommandLineUtils
// FIXME extend CommandLineUtils
{
+
+ private VssCommandLineUtils() {
+ }
+
private static File scmConfDir = new File( System.getProperty( "user.home" ), ".scm" );
-
+
private static Settings settings;
public static void addFiles( Commandline cl, ScmFileSet fileSet )
Modified: maven/scm/trunk/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/GitCommandLineUtils.java
URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/GitCommandLineUtils.java?rev=1134992&r1=1134991&r2=1134992&view=diff
==============================================================================
--- maven/scm/trunk/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/GitCommandLineUtils.java (original)
+++ maven/scm/trunk/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/GitCommandLineUtils.java Sun Jun 12 21:54:27 2011
@@ -37,8 +37,13 @@ import java.util.List;
* @author <a href="mailto:struberg@yahoo.de">Mark Struberg</a>
* @version $Id$
*/
-public class GitCommandLineUtils
+public final class GitCommandLineUtils
{
+
+ private GitCommandLineUtils()
+ {
+ }
+
public static void addTarget( Commandline cl, List<File> files )
{
if ( files == null || files.isEmpty() )
Modified: maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/src/main/java/org/apache/maven/scm/provider/svn/SvnCommandUtils.java
URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/src/main/java/org/apache/maven/scm/provider/svn/SvnCommandUtils.java?rev=1134992&r1=1134991&r2=1134992&view=diff
==============================================================================
--- maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/src/main/java/org/apache/maven/scm/provider/svn/SvnCommandUtils.java (original)
+++ maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/src/main/java/org/apache/maven/scm/provider/svn/SvnCommandUtils.java Sun Jun 12 21:54:27 2011
@@ -27,9 +27,12 @@ import org.codehaus.plexus.util.StringUt
* @author <a href="mailto:jerome@coffeebreaks.org">Jerome Lacoste</a>
* @version $Id$
*/
-public class SvnCommandUtils
+public final class SvnCommandUtils
{
+ private SvnCommandUtils() {
+ }
+
/**
* Add or overrides the username into a url with a svn+ssh scheme.
* <p/>
Modified: maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/src/main/java/org/apache/maven/scm/provider/svn/SvnTagBranchUtils.java
URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/src/main/java/org/apache/maven/scm/provider/svn/SvnTagBranchUtils.java?rev=1134992&r1=1134991&r2=1134992&view=diff
==============================================================================
--- maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/src/main/java/org/apache/maven/scm/provider/svn/SvnTagBranchUtils.java (original)
+++ maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/src/main/java/org/apache/maven/scm/provider/svn/SvnTagBranchUtils.java Sun Jun 12 21:54:27 2011
@@ -28,9 +28,12 @@ import org.codehaus.plexus.util.StringUt
/**
* @version $Id$
*/
-public class SvnTagBranchUtils
+public final class SvnTagBranchUtils
{
+ private SvnTagBranchUtils() {
+ }
+
public static final String[] REVISION_SPECIFIERS = new String[]{"HEAD", "BASE", "COMMITTED", "PREV"};
public static final String SVN_TRUNK = "trunk";
Modified: maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/main/java/org/apache/maven/scm/provider/svn/svnexe/command/SvnCommandLineUtils.java
URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/main/java/org/apache/maven/scm/provider/svn/svnexe/command/SvnCommandLineUtils.java?rev=1134992&r1=1134991&r2=1134992&view=diff
==============================================================================
--- maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/main/java/org/apache/maven/scm/provider/svn/svnexe/command/SvnCommandLineUtils.java (original)
+++ maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/main/java/org/apache/maven/scm/provider/svn/svnexe/command/SvnCommandLineUtils.java Sun Jun 12 21:54:27 2011
@@ -42,8 +42,12 @@ import org.codehaus.plexus.util.cli.Stre
* @author Olivier Lamy
* @version $Id$
*/
-public class SvnCommandLineUtils
+public final class SvnCommandLineUtils
{
+ private SvnCommandLineUtils()
+ {
+ }
+
public static void addTarget( Commandline cl, List<File> files )
throws IOException
{