You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/05/26 05:13:05 UTC
[GitHub] [beam] nbali opened a new pull request, #17764: Fix for creating NOT NULL fields for optional fields
nbali opened a new pull request, #17764:
URL: https://github.com/apache/beam/pull/17764
We create a schema with NOT NULL fields even if the proto field is optional. IMO the code was at the wrong place in the switch-case instead of after it
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17764: Fix for creating NOT NULL fields for optional fields
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17764:
URL: https://github.com/apache/beam/pull/17764#issuecomment-1138160975
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nbali commented on pull request #17764: [BEAM-14522] Fix for creating NOT NULL beam schema fields for optional proto fields
Posted by GitBox <gi...@apache.org>.
nbali commented on PR #17764:
URL: https://github.com/apache/beam/pull/17764#issuecomment-1139231120
replaced by https://github.com/apache/beam/pull/17775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nbali commented on pull request #17764: Fix for creating NOT NULL fields for optional fields
Posted by GitBox <gi...@apache.org>.
nbali commented on PR #17764:
URL: https://github.com/apache/beam/pull/17764#issuecomment-1138785423
R: @aaltay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nbali closed pull request #17764: [BEAM-14522] Fix for creating NOT NULL beam schema fields for optional proto fields
Posted by GitBox <gi...@apache.org>.
nbali closed pull request #17764: [BEAM-14522] Fix for creating NOT NULL beam schema fields for optional proto fields
URL: https://github.com/apache/beam/pull/17764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17764: Fix for creating NOT NULL fields for optional fields
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17764:
URL: https://github.com/apache/beam/pull/17764#issuecomment-1138160967
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17764: Fix for creating NOT NULL fields for optional fields
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17764:
URL: https://github.com/apache/beam/pull/17764#issuecomment-1138160968
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org