[GitHub] [incubator-livy] idzikovsky commented on a change in pull request #249: [LIVY-702]: Submit Spark apps to Kubernetes

[GitBox <gi...@apache.org>]

idzikovsky commented on a change in pull request #249:
URL: https://github.com/apache/incubator-livy/pull/249#discussion_r631094385



##########
File path: rsc/src/main/java/org/apache/livy/rsc/driver/RSCDriver.java
##########
@@ -169,6 +169,13 @@ private void initializeServer() throws Exception {
     // on the cluster, it would be tricky to solve that problem in a generic way.
     livyConf.set(RPC_SERVER_ADDRESS, null);
 
+    // If we are running on Kubernetes, set RPC_SERVER_ADDRESS from "spark.driver.host" option,
+    // which is set in class org.apache.spark.deploy.k8s.features.DriverServiceFeatureStep:
+    // line 61: val driverHostname = s"$resolvedServiceName.${kubernetesConf.namespace()}.svc"
+    if (livyConf.isRunningOnKubernetes()) {
+      livyConf.set(RPC_SERVER_ADDRESS, conf.get("spark.driver.host"));
+    }
+

Review comment:
       I've tried to use the latest Livy with your patches and the issue has not appeared. So it seems like I got that problem because I've backported something wrong.
   Anyway, thank you for help!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org