You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/08/19 02:50:34 UTC

[jira] [Commented] (HIVE-2380) Add ByteArray Datatype

    [ https://issues.apache.org/jira/browse/HIVE-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087435#comment-13087435 ] 

jiraposter@reviews.apache.org commented on HIVE-2380:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1586/
-----------------------------------------------------------

Review request for hive.


Summary
-------

This patch adds bytearray as a new datatype in Hive.


This addresses bug HIVE-2380.
    https://issues.apache.org/jira/browse/HIVE-2380


Diffs
-----

  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableByteArrayObjectInspector.java PRE-CREATION 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableByteArrayObjectInspector.java PRE-CREATION 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableVoidObjectInspector.java 1159452 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java 1159452 
  trunk/serde/src/test/org/apache/hadoop/hive/serde2/TestStatsSerde.java 1159452 
  trunk/serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/MyTestClass.java 1159452 
  trunk/serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/TestBinarySortableSerDe.java 1159452 
  trunk/serde/src/test/org/apache/hadoop/hive/serde2/columnar/TestLazyBinaryColumnarSerDe.java 1159452 
  trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyPrimitive.java 1159452 
  trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java 1159452 
  trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazybinary/MyTestClassBigger.java 1159452 
  trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazybinary/TestLazyBinarySerDe.java 1159452 
  trunk/serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorConverters.java 1159452 
  trunk/serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java 1159452 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java 1159452 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java 1159452 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java 1159452 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java 1159452 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/ByteArrayObjectInspector.java PRE-CREATION 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaByteArrayObjectInspector.java PRE-CREATION 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java 1159452 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java 1159452 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java 1159452 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java 1159452 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryByteArray.java PRE-CREATION 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java 1159452 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyByteArrayObjectInspector.java PRE-CREATION 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java 1159452 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyByteArray.java PRE-CREATION 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java 1159452 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java 1159452 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarSerDe.java 1159452 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarStruct.java 1159452 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1159452 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1159452 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java 1159452 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 1159452 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java 1159452 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToByte.java 1159452 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToDouble.java 1159452 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToFloat.java 1159452 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java 1159452 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java 1159452 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java 1159452 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java 1159452 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/UDFToByteArray.java PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/ba_table1.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/ba_table2.q PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/ba_table1.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/ba_table2.q.out PRE-CREATION 
  trunk/serde/if/serde.thrift 1159452 
  trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h 1159452 
  trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp 1159452 
  trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/Constants.java 1159452 
  trunk/serde/src/gen/thrift/gen-php/serde/serde_constants.php 1159452 
  trunk/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py 1159452 
  trunk/serde/src/gen/thrift/gen-rb/serde_constants.rb 1159452 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 1159452 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 1159452 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1159452 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1159452 

Diff: https://reviews.apache.org/r/1586/diff


Testing
-------

Added and updated unit tests.
Added new system tests.


Thanks,

Ashutosh



> Add ByteArray Datatype
> ----------------------
>
>                 Key: HIVE-2380
>                 URL: https://issues.apache.org/jira/browse/HIVE-2380
>             Project: Hive
>          Issue Type: New Feature
>          Components: Serializers/Deserializers
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: hive-2380.patch
>
>
> Add bytearray as a primitive data type.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira