You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by ma...@apache.org on 2022/07/21 09:06:14 UTC
[incubator-devlake] branch main updated: fix: fix if gitlab api response with no type or issuetype (#2556)
This is an automated email from the ASF dual-hosted git repository.
mappjzc pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
The following commit(s) were added to refs/heads/main by this push:
new 7fe955ab fix: fix if gitlab api response with no type or issuetype (#2556)
7fe955ab is described below
commit 7fe955abe31bfa0953a134aa845186b0cb02e33e
Author: mappjzc <zh...@merico.dev>
AuthorDate: Thu Jul 21 17:06:10 2022 +0800
fix: fix if gitlab api response with no type or issuetype (#2556)
* fix: fix if gitlab api response with no type or issuetype
Check if it setting the type or issue type before value checking.
Nddtfjiang <zh...@merico.dev>
* fix: remove gitlab issue type check
removed gitlab issue type checking.
Nddtfjiang <zh...@merico.dev>
---
plugins/gitlab/tasks/issue_extractor.go | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/plugins/gitlab/tasks/issue_extractor.go b/plugins/gitlab/tasks/issue_extractor.go
index 0324ad3e..d7547ed9 100644
--- a/plugins/gitlab/tasks/issue_extractor.go
+++ b/plugins/gitlab/tasks/issue_extractor.go
@@ -193,10 +193,7 @@ func ExtractApiIssues(taskCtx core.SubTaskContext) error {
if body.ProjectId == 0 {
return nil, nil
}
- //If this is not Issue, ignore
- if body.IssueType != "ISSUE" && body.Type != "ISSUE" {
- return nil, nil
- }
+
results := make([]interface{}, 0, 2)
gitlabIssue, err := convertGitlabIssue(body, data.Options.ProjectId)
if err != nil {