You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "peterxcli (via GitHub)" <gi...@apache.org> on 2026/07/14 04:42:27 UTC
[PR] HDDS-15692. Enable GitHub Copilot code review [1/2] [ozone]
peterxcli opened a new pull request, #10751:
URL: https://github.com/apache/ozone/pull/10751
## What changes were proposed in this pull request?
https://github.com/apache/ozone/pull/10705 was trying to add the auto copilot review request on PR open, but turn out the the copilot is eagerly giving review of every push(even the pr is draft).
Also disable the review on push because sometime you might just accidentally pushed a broken commit then a fix checkstyle/pmd commit, but now it's really possible your pr page has two batch of the copilot review on almost the same snapshot of the code/patch, which is a mass.
## What is the link to the Apache JIRA
[issues.apache.org/jira/browse/HDDS-15692](https://issues.apache.org/jira/browse/HDDS-15692)
## How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests, workflow run on the fork git repo.)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15692. Keep GitHub Copilot code review enable but disable review_on_push [ozone]
Posted by "peterxcli (via GitHub)" <gi...@apache.org>.
peterxcli commented on PR #10751:
URL: https://github.com/apache/ozone/pull/10751#issuecomment-5032623286
> How about we just merge this first then seek for other solution after?
@adoroszlai @jojochuang @ayushtkn what do you think, seems like we don't have a clear consensus at this moment.
1. By merging this, we just go back to previous github PR collaborate workflow, which we have been doing in this way for so many years.
2. we can open another PR for the new copilot setting after we have good understanding on how the copilot and ask infra works.
3. base on my current observation, if the PR author has copilot pro or sth, then the copilot review is triggered everytime they push, and consume their quota. but if user dont have, nothing would happen. (btw the copilot review is actually really quota-consuming and easy to hit the limit so "Copilot was unable to review this pull request because the user who requested the review has reached their quota limit." start to appearing.
<img width="389" height="116" alt="image" src="https://github.com/user-attachments/assets/e9b9cde4-48f6-4987-90e2-2e6d34beaf7c" />
<img width="195" height="284" alt="image" src="https://github.com/user-attachments/assets/40283937-3d27-4a36-90cb-df0e9f87950a" />
above charts show that my quota is occupy at 70% in one day just for reviewing my draft pr: #10743.
I don't use github copilot for other usage tho.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15692. Keep GitHub Copilot code review enable but disable review_on_push [ozone]
Posted by "peterxcli (via GitHub)" <gi...@apache.org>.
peterxcli commented on PR #10751:
URL: https://github.com/apache/ozone/pull/10751#issuecomment-4966374452
> If we remove review_on_push: true, we get initial review, but need to request follow-up manually. Why not make all reviews manual in that case?
actually I'm not really sure what would happend(all manually or review on opening) if the copilot is enable and review_on_push is disable
> I also find copilot review annoying, so I would be totally fine removing it completely. But others find it useful and discussed using it.
so keep it to review on demand would be the consensus.
> I did not get any copilot review on my PRs (https://github.com/apache/ozone/pull/10730, https://github.com/apache/ozone/pull/10738, https://github.com/apache/ozone/pull/10739). Not sure why, maybe it needs to be enabled in personal settings?
I also have no idea.
> In any case, we should keep review_drafts: true, to avoid unnecessary CI.
good point, added it back
> Please make sure to reflect the change in the title. Also, what does [1/2] mean?
ok, the original "[1/2]" means this is the patch for the same [HDDS-15692](https://issues.apache.org/jira/browse/HDDS-15692) ticket which https://github.com/apache/ozone/pull/10705 is the first PR of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15692. Trigger GitHub Copilot code review only when PR is opened [ozone]
Posted by "peterxcli (via GitHub)" <gi...@apache.org>.
peterxcli commented on PR #10751:
URL: https://github.com/apache/ozone/pull/10751#issuecomment-5077552159
Thanks everyone for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15692. Trigger GitHub Copilot code review only when PR is opened [ozone]
Posted by "peterxcli (via GitHub)" <gi...@apache.org>.
peterxcli merged PR #10751:
URL: https://github.com/apache/ozone/pull/10751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15692. Keep GitHub Copilot code review enable but disable review_on_push [ozone]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on PR #10751:
URL: https://github.com/apache/ozone/pull/10751#issuecomment-4978624177
Disabling on new pushes, definitely makes sense. I just checked my github profile: https://github.com/settings/copilot/features
and it has 1500 AI credits as budget.
But now I have a doubt, like if it working for me only or for all, because I saw this written there
```
GitHub Copilot Pro is active for your account
```
If only people with GitHub Copilot pro can use this and everyone else will be getting messages like above
```
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
```
Maybe we need to reconsider this & make it manual only, like one who has credits can leverage that. I am having this for free, not sure if ASF gave it or from where.
I was under the assumption that it would be project credits or so. I am even not sure if it is using individual person's credit, then is it fair to use their automatically. Hopefully it isn't any violation of policy or so
@jojochuang can you help check/confirm around this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15692. Enable GitHub Copilot code review [1/2] [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #10751:
URL: https://github.com/apache/ozone/pull/10751#issuecomment-4965961158
Thanks @peterxcli for raising this concern.
- If we remove `review_on_push: true`, we get initial review, but need to request follow-up manually. Why not make all reviews manual in that case?
- I also find copilot review annoying, so I would be totally fine removing it completely. But others find it useful and discussed using it.
- I did not get any copilot review on my PRs (#10730, #10738, #10739). Not sure why, maybe it needs to be enabled in personal settings?
- In any case, we should keep `review_drafts: true`, to avoid unnecessary CI.
- Please make sure to reflect the change in the title. Also, what does `[1/2]` mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15692. Keep GitHub Copilot code review enable but disable review_on_push [ozone]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on PR #10751:
URL: https://github.com/apache/ozone/pull/10751#issuecomment-4978640720
> Not sure why, maybe it needs to be enabled in personal settings?
@adoroszlai can you check here if it shows all repositories, I am just guessing that maybe a reason
https://github.com/settings/copilot/coding_agent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15692. Keep GitHub Copilot code review enable but disable review_on_push [ozone]
Posted by "peterxcli (via GitHub)" <gi...@apache.org>.
peterxcli commented on PR #10751:
URL: https://github.com/apache/ozone/pull/10751#issuecomment-5019521230
How about we just merge this first then seek for other solution after?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org