You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Furkan KAMACI (JIRA)" <ji...@apache.org> on 2014/03/08 17:01:42 UTC
[jira] [Updated] (LUCENE-5506) Ignoring the Return Values Of
Immutable Objects
[ https://issues.apache.org/jira/browse/LUCENE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Furkan KAMACI updated LUCENE-5506:
----------------------------------
Attachment: LUCENE-5506.patch
> Ignoring the Return Values Of Immutable Objects
> -----------------------------------------------
>
> Key: LUCENE-5506
> URL: https://issues.apache.org/jira/browse/LUCENE-5506
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 4.6.1, 4.7
> Reporter: Furkan KAMACI
> Priority: Minor
> Fix For: 4.8
>
> Attachments: LUCENE-5506.patch
>
>
> I was checking the source code of Lucene and I realized that return values of immutable objects are ignored at CSVUtil.java and Compile.java as follows:
> *CSVUtil.java*:
> {code}
> /**
> * Quote and escape input value for CSV
> */
> public static String quoteEscape(String original) {
> String result = original;
>
> if (result.indexOf('\"') >= 0) {
> result.replace("\"", ESCAPED_QUOTE);
> }
> if(result.indexOf(COMMA) >= 0) {
> result = "\"" + result + "\"";
> }
> return result;
> }
> {code}
> *Compile.java*
> {code}
> if (args.length < 1) {
> return;
> }
> args[0].toUpperCase(Locale.ROOT);
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org