You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2015/08/29 00:19:25 UTC
Review Request 37908: Silence oversubscription logging
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37908/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Resource estimates are continuously written to the logs even though they are empty (as with the majority of Mesos clusters at the moment). To reduce the noise, this patch moves log lines for empty resources to VLOG(2).
Diffs
-----
src/slave/slave.cpp 8cfad7b86675b10c98524174975828bbcf47aed2
Diff: https://reviews.apache.org/r/37908/diff/
Testing
-------
make check - with and without the patch, verifying the log statements.
Thanks,
Niklas Nielsen
Re: Review Request 37908: Silence oversubscription logging
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Aug. 28, 2015, 3:42 p.m., Jie Yu wrote:
> > src/slave/slave.cpp, lines 4240-4248
> > <https://reviews.apache.org/r/37908/diff/1/?file=1058395#file1058395line4240>
> >
> > Hum, why zero is a special case here? What if the RE initially returns 10cpus, and due to some reaons, it returns nothing later. Do we still need to get notified about this change?
> >
> > I would suggest changing LOG(INFO) to VLOG(1) without other changes.
Alrighty - will do; don't have any strong opinions other than getting it out of non-oversubscribed cluster logs :)
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37908/#review96940
-----------------------------------------------------------
On Aug. 28, 2015, 3:19 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37908/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2015, 3:19 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Resource estimates are continuously written to the logs even though they are empty (as with the majority of Mesos clusters at the moment). To reduce the noise, this patch moves log lines for empty resources to VLOG(2).
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 8cfad7b86675b10c98524174975828bbcf47aed2
>
> Diff: https://reviews.apache.org/r/37908/diff/
>
>
> Testing
> -------
>
> make check - with and without the patch, verifying the log statements.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 37908: Silence oversubscription logging
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37908/#review96940
-----------------------------------------------------------
src/slave/slave.cpp (line 4226)
<https://reviews.apache.org/r/37908/#comment152635>
I think VLOG(1) is more appropriate.
src/slave/slave.cpp (lines 4240 - 4248)
<https://reviews.apache.org/r/37908/#comment152638>
Hum, why zero is a special case here? What if the RE initially returns 10cpus, and due to some reaons, it returns nothing later. Do we still need to get notified about this change?
I would suggest changing LOG(INFO) to VLOG(1) without other changes.
- Jie Yu
On Aug. 28, 2015, 10:19 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37908/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2015, 10:19 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Resource estimates are continuously written to the logs even though they are empty (as with the majority of Mesos clusters at the moment). To reduce the noise, this patch moves log lines for empty resources to VLOG(2).
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 8cfad7b86675b10c98524174975828bbcf47aed2
>
> Diff: https://reviews.apache.org/r/37908/diff/
>
>
> Testing
> -------
>
> make check - with and without the patch, verifying the log statements.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 37908: Silence oversubscription logging
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37908/#review97351
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 31, 2015, 6:28 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37908/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 6:28 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Resource estimates are continuously written to the logs even though they are empty (as with the majority of Mesos clusters at the moment). To reduce the noise, this patch moves log lines for empty resources to VLOG(1).
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 8cfad7b86675b10c98524174975828bbcf47aed2
>
> Diff: https://reviews.apache.org/r/37908/diff/
>
>
> Testing
> -------
>
> make check - with and without the patch, verifying the log statements.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 37908: Silence oversubscription logging
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37908/#review97137
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37908]
All tests passed.
- Mesos ReviewBot
On Aug. 31, 2015, 6:28 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37908/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 6:28 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Resource estimates are continuously written to the logs even though they are empty (as with the majority of Mesos clusters at the moment). To reduce the noise, this patch moves log lines for empty resources to VLOG(1).
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 8cfad7b86675b10c98524174975828bbcf47aed2
>
> Diff: https://reviews.apache.org/r/37908/diff/
>
>
> Testing
> -------
>
> make check - with and without the patch, verifying the log statements.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 37908: Silence oversubscription logging
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37908/
-----------------------------------------------------------
(Updated Aug. 31, 2015, 11:28 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
Reduced patch to move LOG(INFO) for oversubscription into VLOG(1)
Repository: mesos
Description (updated)
-------
Resource estimates are continuously written to the logs even though they are empty (as with the majority of Mesos clusters at the moment). To reduce the noise, this patch moves log lines for empty resources to VLOG(1).
Diffs (updated)
-----
src/slave/slave.cpp 8cfad7b86675b10c98524174975828bbcf47aed2
Diff: https://reviews.apache.org/r/37908/diff/
Testing
-------
make check - with and without the patch, verifying the log statements.
Thanks,
Niklas Nielsen
Re: Review Request 37908: Silence oversubscription logging
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37908/#review96974
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37908]
All tests passed.
- Mesos ReviewBot
On Aug. 28, 2015, 10:19 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37908/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2015, 10:19 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Resource estimates are continuously written to the logs even though they are empty (as with the majority of Mesos clusters at the moment). To reduce the noise, this patch moves log lines for empty resources to VLOG(2).
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 8cfad7b86675b10c98524174975828bbcf47aed2
>
> Diff: https://reviews.apache.org/r/37908/diff/
>
>
> Testing
> -------
>
> make check - with and without the patch, verifying the log statements.
>
>
> Thanks,
>
> Niklas Nielsen
>
>