You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/17 17:36:15 UTC
[GitHub] [camel-k] phantomjinx opened a new pull request, #3823: e2e fixes and changes
phantomjinx opened a new pull request, #3823:
URL: https://github.com/apache/camel-k/pull/3823
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3823: e2e fixes and changes
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3823:
URL: https://github.com/apache/camel-k/pull/3823#issuecomment-1357127888
@phantomjinx Yes, but there is validation failures that need to be fixed before merging. Could you update the pull req?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] phantomjinx commented on pull request #3823: e2e fixes and changes
Posted by GitBox <gi...@apache.org>.
phantomjinx commented on PR #3823:
URL: https://github.com/apache/camel-k/pull/3823#issuecomment-1319922610
> @phantomjinx Is it too early yet to add `windows-latest` to the `build` workflow OS matrix?
Am afraid it is. There are several issues that are out of our hands. The most serious being that the windows runners do not support windows docker in experimental mode that allows for linux containers. That means that images for all the base images for all elements of the operator and integrations must be available as windows - and they are not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] phantomjinx commented on pull request #3823: e2e fixes and changes
Posted by GitBox <gi...@apache.org>.
phantomjinx commented on PR #3823:
URL: https://github.com/apache/camel-k/pull/3823#issuecomment-1354729948
Despite, the failure to initiate tests on windows, the changes should still be good. Can this be merged, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi merged pull request #3823: e2e fixes and changes
Posted by GitBox <gi...@apache.org>.
tadayosi merged PR #3823:
URL: https://github.com/apache/camel-k/pull/3823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] phantomjinx commented on pull request #3823: e2e fixes and changes
Posted by GitBox <gi...@apache.org>.
phantomjinx commented on PR #3823:
URL: https://github.com/apache/camel-k/pull/3823#issuecomment-1319924829
> @phantomjinx Is it too early yet to add `windows-latest` to the `build` workflow OS matrix?
Yeah. Lets give it a try (sorry misread you comment in my earlier reply).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] phantomjinx commented on pull request #3823: e2e fixes and changes
Posted by GitBox <gi...@apache.org>.
phantomjinx commented on PR #3823:
URL: https://github.com/apache/camel-k/pull/3823#issuecomment-1339490522
> > @phantomjinx Is it too early yet to add `windows-latest` to the `build` workflow OS matrix?
>
> Yeah. Lets give it a try (sorry misread you comment in my earlier reply).
Tried enabling `windows-latest` on `build` workflow and it fails.
1. Requires install of a distro in `Windows Subsystem for Linux`. So used:
```
- name: Setup WSL (if on Windows)
uses: Vampire/setup-wsl@v1.3.4
if: runner.os == 'Windows'
```
1. Fails to execute subshell scripts from `make` due to this issue: https://github.com/actions/runner/issues/1328
```
./script/get_catalog.sh 1.16.0-SNAPSHOT
/bin/bash: D:acamel-kcamel-kscriptget_catalog.sh: No such file or directory
mingw32-make: *** [Makefile:325: build-resources] Error 127
Error: Process completed with exit code 2.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] phantomjinx commented on pull request #3823: e2e fixes and changes
Posted by GitBox <gi...@apache.org>.
phantomjinx commented on PR #3823:
URL: https://github.com/apache/camel-k/pull/3823#issuecomment-1357931879
> @phantomjinx Yes, but there is validation failures that need to be fixed before merging. Could you update the pull req?
validation failures sorted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3823: e2e fixes and changes
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3823:
URL: https://github.com/apache/camel-k/pull/3823#issuecomment-1319583188
@phantomjinx Is it too early yet to add `windows-latest` to the `build` workflow OS matrix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3823: e2e fixes and changes
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3823:
URL: https://github.com/apache/camel-k/pull/3823#issuecomment-1334767160
The `install` check failure is a known one which I'm already working on, and the `local` one is a temporary failure, so if you fix the validation failures then I think it's ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org