You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/20 10:23:48 UTC

[GitHub] [airflow] owlphi edited a comment on pull request #13138: Fix insert_all in bigquery hook

owlphi edited a comment on pull request #13138:
URL: https://github.com/apache/airflow/pull/13138#issuecomment-748588802


   Hi @turbaszek 
   
   Thank you for reviewing my PR. I am not sure if I understood well, so I may need your help. 
   
   The issue is in the bigquery hook, not the operators.
   
   I have compare the code **insert_rows** for the two version you mentioned: v2.0.0 vs v1.28.0. The logic seems the same:
   
   https://github.com/googleapis/python-bigquery/blob/v1.28.0/google/cloud/bigquery/client.py#L2780-#L2840
   
   https://github.com/googleapis/python-bigquery/blob/v2.0.0/google/cloud/bigquery/client.py#L2776-#L2836
   
    If you could point it out where the different logic is, it will help me. Otherwise I am not sure the version 2.0.0 will fix the issue. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org