You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by seanbarzilay <gi...@git.apache.org> on 2016/10/27 07:46:34 UTC
[GitHub] tinkerpop pull request #467: Added getProjectKeys in ProjectStep
GitHub user seanbarzilay opened a pull request:
https://github.com/apache/tinkerpop/pull/467
Added getProjectKeys in ProjectStep
One of my strategies requires getting the project keys
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/seanbarzilay/tinkerpop master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/467.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #467
----
commit 8ba3119ecb044a9df1ce704c056ba4bb16bbf3ca
Author: sbarzilay <se...@github.com>
Date: 2016-08-03T09:12:39Z
added missing feature requirement
commit 09eb2a568211deb08e5a92ccc701109969f3ab68
Author: sbarzilay <se...@gmail.com>
Date: 2016-10-27T07:23:14Z
added getProjectKeys in ProjectStep
commit 9c5204eddfae53aa35818ad854f4eb87d73668ad
Author: sbarzilay <se...@gmail.com>
Date: 2016-10-27T07:39:19Z
Merge remote-tracking branch 'upstream/master'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #467: Added getProjectKeys in ProjectStep
Posted by seanbarzilay <gi...@git.apache.org>.
Github user seanbarzilay closed the pull request at:
https://github.com/apache/tinkerpop/pull/467
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #467: Added getProjectKeys in ProjectStep
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/467
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #467: Added getProjectKeys in ProjectStep
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/467
pretty: VOTE +1 - give the last comment @okram laid out there it sounds like he will handle the merge now that you have 3X +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #467: Added getProjectKeys in ProjectStep
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/467
merged. in the future, please update CHANGELOG or provide a note about what to add to the CHANGELOG on merge. Also, I just addded you change because it was targeted to master and it can go in `tp32`. Also, should I want to make this an `UnmodifiableList` that is returned. Is that okay? thanks for the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #467: Added getProjectKeys in ProjectStep
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/467
I'm happy to merge this. Question -- why do you need this information? (out of curiosity).
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #467: Added getProjectKeys in ProjectStep
Posted by seanbarzilay <gi...@git.apache.org>.
Github user seanbarzilay commented on the issue:
https://github.com/apache/tinkerpop/pull/467
I have my own implementation for ProjectStep in [Unipop](https://github.com/unipop-graph/unipop) that optimizes the number of queries I make
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #467: Added getProjectKeys in ProjectStep
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/467
(please manually close this PR)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #467: Added getProjectKeys in ProjectStep
Posted by seanbarzilay <gi...@git.apache.org>.
Github user seanbarzilay commented on the issue:
https://github.com/apache/tinkerpop/pull/467
@okram wonderful
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #467: Added getProjectKeys in ProjectStep
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/467
@seanbarzilay do you mind cleaning up the commit history a bit? It would be nice to have one commit that we can merge for this small change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #467: Added getProjectKeys in ProjectStep
Posted by seanbarzilay <gi...@git.apache.org>.
Github user seanbarzilay commented on the issue:
https://github.com/apache/tinkerpop/pull/467
@spmallette done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---