You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/01 07:44:40 UTC

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #178: [MRESOLVER-7] download poms in parallel

cstamas commented on code in PR #178:
URL: https://github.com/apache/maven-resolver/pull/178#discussion_r985065751


##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/bf/BfDependencyCollector.java:
##########
@@ -365,6 +477,64 @@ else if ( descriptorResult == DataPool.NO_DESCRIPTOR )
         return descriptorResult;
     }
 
+    static class ParallelDescriptorResolver
+    {
+        final ExecutorService executorService;

Review Comment:
   For now I'd follow very same pattern as in connector, it creates executor for each remote repos (not good, but not bad either). So creating executor per resolve invocation is also ok. Later, we could do something around this, but it requires larger scale changes, so leave it for now IMHO



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org