You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/12/13 18:36:24 UTC
[GitHub] [accumulo] ctubbsii commented on a change in pull request #2384: Fix IDE suggested string usage issues.
ctubbsii commented on a change in pull request #2384:
URL: https://github.com/apache/accumulo/pull/2384#discussion_r768013884
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/cluster/ClusterConfigParser.java
##########
@@ -94,20 +93,20 @@ public static void outputShellVariables(Map<String,String> config, PrintStream o
}
if (config.containsKey("compaction.coordinator")) {
- out.println(String.format(PROPERTY_FORMAT, "COORDINATOR_HOSTS",
- config.get("compaction.coordinator")));
+ out.printf((PROPERTY_FORMAT) + "%n", "COORDINATOR_HOSTS",
Review comment:
```suggestion
out.printf(PROPERTY_FORMAT + "%n", "COORDINATOR_HOSTS",
```
##########
File path: server/base/src/main/java/org/apache/accumulo/server/util/DumpZookeeper.java
##########
@@ -129,7 +129,7 @@ private static void write(PrintStream out, int indent, String fmt, Object... arg
for (int i = 0; i < indent; i++) {
out.print(" ");
}
- out.println(String.format(fmt, args));
+ out.printf((fmt) + "%n", args);
Review comment:
```suggestion
out.printf(fmt + "%n", args);
```
##########
File path: server/base/src/main/java/org/apache/accumulo/server/util/LocalityCheck.java
##########
@@ -83,8 +83,8 @@ public int run(String[] args) throws Exception {
for (Entry<String,Long> entry : totalBlocks.entrySet()) {
final String host = entry.getKey();
final Long blocksForHost = entry.getValue();
- System.out.println(String.format("%15s %5.1f %8d", host,
- (localBlocks.get(host) * 100.) / blocksForHost, blocksForHost));
+ System.out.printf("%15s %5.1f %8d%n", host,
+ (localBlocks.get(host) * 100.) / blocksForHost, blocksForHost);
Review comment:
```suggestion
localBlocks.get(host) * 100. / blocksForHost, blocksForHost);
```
##########
File path: minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloRunner.java
##########
@@ -288,22 +288,22 @@ private static void setMemoryOnConfig(MiniAccumuloConfig config, String memorySt
private static void printInfo(MiniAccumuloCluster accumulo, int shutdownPort) {
System.out.println("Mini Accumulo Cluster\n");
- System.out.println(String.format(FORMAT_STRING, "Directory:",
- accumulo.getConfig().getDir().getAbsoluteFile()));
- System.out.println(String.format(FORMAT_STRING, "Logs:",
- accumulo.getConfig().getImpl().getLogDir().getAbsoluteFile()));
- System.out.println(
- String.format(FORMAT_STRING, "Instance Name:", accumulo.getConfig().getInstanceName()));
- System.out.println(
- String.format(FORMAT_STRING, "Root Password:", accumulo.getConfig().getRootPassword()));
- System.out.println(String.format(FORMAT_STRING, "ZooKeeper:", accumulo.getZooKeepers()));
+ System.out.printf((FORMAT_STRING) + "%n", "Directory:",
+ accumulo.getConfig().getDir().getAbsoluteFile());
+ System.out.printf((FORMAT_STRING) + "%n", "Logs:",
+ accumulo.getConfig().getImpl().getLogDir().getAbsoluteFile());
+ System.out.printf((FORMAT_STRING) + "%n", "Instance Name:",
+ accumulo.getConfig().getInstanceName());
+ System.out.printf((FORMAT_STRING) + "%n", "Root Password:",
+ accumulo.getConfig().getRootPassword());
+ System.out.printf((FORMAT_STRING) + "%n", "ZooKeeper:", accumulo.getZooKeepers());
for (Pair<ServerType,Integer> pair : accumulo.getDebugPorts()) {
- System.out.println(String.format(FORMAT_STRING, pair.getFirst().prettyPrint() + " JDWP Host:",
- "localhost:" + pair.getSecond()));
+ System.out.printf((FORMAT_STRING) + "%n", pair.getFirst().prettyPrint() + " JDWP Host:",
Review comment:
```suggestion
System.out.printf(FORMAT_STRING + "%n", pair.getFirst().prettyPrint() + " JDWP Host:",
```
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/cluster/ClusterConfigParser.java
##########
@@ -94,20 +93,20 @@ public static void outputShellVariables(Map<String,String> config, PrintStream o
}
if (config.containsKey("compaction.coordinator")) {
- out.println(String.format(PROPERTY_FORMAT, "COORDINATOR_HOSTS",
- config.get("compaction.coordinator")));
+ out.printf((PROPERTY_FORMAT) + "%n", "COORDINATOR_HOSTS",
+ config.get("compaction.coordinator"));
}
if (config.containsKey("compaction.compactor.queue")) {
- out.println(String.format(PROPERTY_FORMAT, "COMPACTION_QUEUES",
- config.get("compaction.compactor.queue")));
+ out.printf((PROPERTY_FORMAT) + "%n", "COMPACTION_QUEUES",
+ config.get("compaction.compactor.queue"));
}
String queues = config.get("compaction.compactor.queue");
if (StringUtils.isNotEmpty(queues)) {
String[] q = queues.split(" ");
for (int i = 0; i < q.length; i++) {
if (config.containsKey("compaction.compactor." + q[i])) {
- out.println(String.format(PROPERTY_FORMAT, "COMPACTOR_HOSTS_" + q[i],
- config.get("compaction.compactor." + q[i])));
+ out.printf((PROPERTY_FORMAT) + "%n", "COMPACTOR_HOSTS_" + q[i],
Review comment:
```suggestion
out.printf(PROPERTY_FORMAT + "%n", "COMPACTOR_HOSTS_" + q[i],
```
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/cluster/ClusterConfigParser.java
##########
@@ -94,20 +93,20 @@ public static void outputShellVariables(Map<String,String> config, PrintStream o
}
if (config.containsKey("compaction.coordinator")) {
- out.println(String.format(PROPERTY_FORMAT, "COORDINATOR_HOSTS",
- config.get("compaction.coordinator")));
+ out.printf((PROPERTY_FORMAT) + "%n", "COORDINATOR_HOSTS",
+ config.get("compaction.coordinator"));
}
if (config.containsKey("compaction.compactor.queue")) {
- out.println(String.format(PROPERTY_FORMAT, "COMPACTION_QUEUES",
- config.get("compaction.compactor.queue")));
+ out.printf((PROPERTY_FORMAT) + "%n", "COMPACTION_QUEUES",
Review comment:
```suggestion
out.printf(PROPERTY_FORMAT + "%n", "COMPACTION_QUEUES",
```
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/cluster/ClusterConfigParser.java
##########
@@ -83,8 +83,7 @@ private static void flatten(String parentKey, String key, Object value,
public static void outputShellVariables(Map<String,String> config, PrintStream out) {
for (String section : SECTIONS) {
if (config.containsKey(section)) {
- out.println(
- String.format(PROPERTY_FORMAT, section.toUpperCase() + "_HOSTS", config.get(section)));
+ out.printf((PROPERTY_FORMAT) + "%n", section.toUpperCase() + "_HOSTS", config.get(section));
Review comment:
```suggestion
out.printf(PROPERTY_FORMAT + "%n", section.toUpperCase() + "_HOSTS", config.get(section));
```
##########
File path: test/src/main/java/org/apache/accumulo/test/GetManagerStats.java
##########
@@ -148,11 +148,11 @@ public static void main(String[] args) throws Exception {
}
}
- private static void out(int indent, String string, Object... args) {
+ private static void out(int indent, String fmtString, Object... args) {
for (int i = 0; i < indent; i++) {
System.out.print(" ");
}
- System.out.println(String.format(string, args));
+ System.out.printf((fmtString) + "%n", args);
Review comment:
```suggestion
System.out.printf(fmtString + "%n", args);
```
##########
File path: minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloRunner.java
##########
@@ -288,22 +288,22 @@ private static void setMemoryOnConfig(MiniAccumuloConfig config, String memorySt
private static void printInfo(MiniAccumuloCluster accumulo, int shutdownPort) {
System.out.println("Mini Accumulo Cluster\n");
- System.out.println(String.format(FORMAT_STRING, "Directory:",
- accumulo.getConfig().getDir().getAbsoluteFile()));
- System.out.println(String.format(FORMAT_STRING, "Logs:",
- accumulo.getConfig().getImpl().getLogDir().getAbsoluteFile()));
- System.out.println(
- String.format(FORMAT_STRING, "Instance Name:", accumulo.getConfig().getInstanceName()));
- System.out.println(
- String.format(FORMAT_STRING, "Root Password:", accumulo.getConfig().getRootPassword()));
- System.out.println(String.format(FORMAT_STRING, "ZooKeeper:", accumulo.getZooKeepers()));
+ System.out.printf((FORMAT_STRING) + "%n", "Directory:",
+ accumulo.getConfig().getDir().getAbsoluteFile());
+ System.out.printf((FORMAT_STRING) + "%n", "Logs:",
+ accumulo.getConfig().getImpl().getLogDir().getAbsoluteFile());
+ System.out.printf((FORMAT_STRING) + "%n", "Instance Name:",
+ accumulo.getConfig().getInstanceName());
+ System.out.printf((FORMAT_STRING) + "%n", "Root Password:",
+ accumulo.getConfig().getRootPassword());
+ System.out.printf((FORMAT_STRING) + "%n", "ZooKeeper:", accumulo.getZooKeepers());
Review comment:
```suggestion
System.out.printf(FORMAT_STRING + "%n", "Directory:",
accumulo.getConfig().getDir().getAbsoluteFile());
System.out.printf(FORMAT_STRING + "%n", "Logs:",
accumulo.getConfig().getImpl().getLogDir().getAbsoluteFile());
System.out.printf(FORMAT_STRING + "%n", "Instance Name:",
accumulo.getConfig().getInstanceName());
System.out.printf(FORMAT_STRING + "%n", "Root Password:",
accumulo.getConfig().getRootPassword());
System.out.printf(FORMAT_STRING + "%n", "ZooKeeper:", accumulo.getZooKeepers());
```
##########
File path: minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloRunner.java
##########
@@ -288,22 +288,22 @@ private static void setMemoryOnConfig(MiniAccumuloConfig config, String memorySt
private static void printInfo(MiniAccumuloCluster accumulo, int shutdownPort) {
System.out.println("Mini Accumulo Cluster\n");
- System.out.println(String.format(FORMAT_STRING, "Directory:",
- accumulo.getConfig().getDir().getAbsoluteFile()));
- System.out.println(String.format(FORMAT_STRING, "Logs:",
- accumulo.getConfig().getImpl().getLogDir().getAbsoluteFile()));
- System.out.println(
- String.format(FORMAT_STRING, "Instance Name:", accumulo.getConfig().getInstanceName()));
- System.out.println(
- String.format(FORMAT_STRING, "Root Password:", accumulo.getConfig().getRootPassword()));
- System.out.println(String.format(FORMAT_STRING, "ZooKeeper:", accumulo.getZooKeepers()));
+ System.out.printf((FORMAT_STRING) + "%n", "Directory:",
+ accumulo.getConfig().getDir().getAbsoluteFile());
+ System.out.printf((FORMAT_STRING) + "%n", "Logs:",
+ accumulo.getConfig().getImpl().getLogDir().getAbsoluteFile());
+ System.out.printf((FORMAT_STRING) + "%n", "Instance Name:",
+ accumulo.getConfig().getInstanceName());
+ System.out.printf((FORMAT_STRING) + "%n", "Root Password:",
+ accumulo.getConfig().getRootPassword());
+ System.out.printf((FORMAT_STRING) + "%n", "ZooKeeper:", accumulo.getZooKeepers());
for (Pair<ServerType,Integer> pair : accumulo.getDebugPorts()) {
- System.out.println(String.format(FORMAT_STRING, pair.getFirst().prettyPrint() + " JDWP Host:",
- "localhost:" + pair.getSecond()));
+ System.out.printf((FORMAT_STRING) + "%n", pair.getFirst().prettyPrint() + " JDWP Host:",
+ "localhost:" + pair.getSecond());
}
- System.out.println(String.format(FORMAT_STRING, "Shutdown Port:", shutdownPort));
+ System.out.printf((FORMAT_STRING) + "%n", "Shutdown Port:", shutdownPort);
Review comment:
```suggestion
System.out.printf(FORMAT_STRING + "%n", "Shutdown Port:", shutdownPort);
```
##########
File path: test/src/main/java/org/apache/accumulo/test/TestMultiTableIngest.java
##########
@@ -95,8 +95,7 @@ public static void main(String[] args) throws Exception {
// populate
for (int i = 0; i < opts.count; i++) {
Mutation m = new Mutation(new Text(String.format("%06d", i)));
- m.put(new Text("col" + Integer.toString((i % 3) + 1)), new Text("qual"),
- new Value("junk"));
+ m.put(new Text("col" + ((i % 3) + 1)), new Text("qual"), new Value("junk"));
Review comment:
I think there's a CharSequence version of this:
```suggestion
m.put("col" + ((i % 3) + 1), "qual", "junk");
```
##########
File path: test/src/main/java/org/apache/accumulo/test/functional/TabletIT.java
##########
@@ -85,8 +85,7 @@ public void createTableTest(AccumuloClient accumuloClient, String tableName, boo
// populate
for (int i = 0; i < N; i++) {
Mutation m = new Mutation(new Text(String.format("%05d", i)));
- m.put(new Text("col" + Integer.toString((i % 3) + 1)), new Text("qual"),
- new Value("junk"));
+ m.put(new Text("col" + ((i % 3) + 1)), new Text("qual"), new Value("junk"));
Review comment:
```suggestion
m.put("col" + ((i % 3) + 1), "qual", "junk");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org