You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jim Jagielski <ji...@jaguNET.com> on 2012/03/19 15:31:05 UTC

Re: svn commit: r1302444 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c

On Mar 19, 2012, at 9:53 AM, rpluem@apache.org wrote:
> Modified: httpd/httpd/trunk/modules/proxy/mod_proxy.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy.c?rev=1302444&r1=1302443&r2=1302444&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/proxy/mod_proxy.c (original)
> +++ httpd/httpd/trunk/modules/proxy/mod_proxy.c Mon Mar 19 13:53:28 2012
> @@ -2461,11 +2461,11 @@ static void child_init(apr_pool_t *p, se
>                 ap_proxy_hashfunc(reverse->s->name, PROXY_HASHFUNC_FNV);
>             /* Do not disable worker in case of errors */
>             reverse->s->status |= PROXY_WORKER_IGNORE_ERRORS;
> -            conf->reverse = reverse;
>             ap_proxy_initialize_worker(conf->reverse, s, conf->pool);
>             /* Disable address cache for generic reverse worker */
>             reverse->s->is_address_reusable = 0;
>         }
> +        conf->reverse = reverse;
>         s = s->next;
>     }
> }
> 

Is that right? Doesn't that mean that the ap_proxy_initialize_worker()
call gets an unknown/undefined 1st arg (conf->reverse)??

RE: svn commit: r1302444 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c

Posted by Plüm, Rüdiger, Vodafone Group <ru...@vodafone.com>.

> -----Original Message-----
> From: Jim Jagielski > Sent: Montag, 19. März 2012 20:16
> To: dev@httpd.apache.org
> Subject: Re: svn commit: r1302444 - in /httpd/httpd/trunk: CHANGES
> modules/proxy/mod_proxy.c
> 
> Cool.. Are these candidates for 2.4.x?

Yes, but currently ENOTIME for backport proposals. So if you want...

Regards

Rüdiger



Re: svn commit: r1302444 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c

Posted by Jim Jagielski <ji...@jaguNET.com>.
Cool.. Are these candidates for 2.4.x?

On Mar 19, 2012, at 10:55 AM, Plüm, Rüdiger, VF-Group wrote:

> 
> 
>> -----Original Message-----
>> From: Jim Jagielski [mailto:jim@jaguNET.com]
>> Sent: Montag, 19. März 2012 15:31
>> To: dev@httpd.apache.org
>> Subject: Re: svn commit: r1302444 - in /httpd/httpd/trunk: CHANGES
>> modules/proxy/mod_proxy.c
>> 
>> 
>> On Mar 19, 2012, at 9:53 AM, rpluem@apache.org wrote:
>>> Modified: httpd/httpd/trunk/modules/proxy/mod_proxy.c
>>> URL:
>> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy.
>> c?rev=1302444&r1=1302443&r2=1302444&view=diff
>>> 
>> =======================================================================
>> =======
>>> --- httpd/httpd/trunk/modules/proxy/mod_proxy.c (original)
>>> +++ httpd/httpd/trunk/modules/proxy/mod_proxy.c Mon Mar 19 13:53:28
>> 2012
>>> @@ -2461,11 +2461,11 @@ static void child_init(apr_pool_t *p, se
>>>                ap_proxy_hashfunc(reverse->s->name,
>> PROXY_HASHFUNC_FNV);
>>>            /* Do not disable worker in case of errors */
>>>            reverse->s->status |= PROXY_WORKER_IGNORE_ERRORS;
>>> -            conf->reverse = reverse;
>>>            ap_proxy_initialize_worker(conf->reverse, s, conf->pool);
>>>            /* Disable address cache for generic reverse worker */
>>>            reverse->s->is_address_reusable = 0;
>>>        }
>>> +        conf->reverse = reverse;
>>>        s = s->next;
>>>    }
>>> }
>>> 
>> 
>> Is that right? Doesn't that mean that the ap_proxy_initialize_worker()
>> call gets an unknown/undefined 1st arg (conf->reverse)??
> 
> Yes :-). The original reporter already pointed that out. Fixed in r1302483.
> 
> Regards
> 
> Rüdiger
> 


RE: svn commit: r1302444 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c

Posted by Plüm, Rüdiger, VF-Group <ru...@vodafone.com>.

> -----Original Message-----
> From: Jim Jagielski [mailto:jim@jaguNET.com]
> Sent: Montag, 19. März 2012 15:31
> To: dev@httpd.apache.org
> Subject: Re: svn commit: r1302444 - in /httpd/httpd/trunk: CHANGES
> modules/proxy/mod_proxy.c
> 
> 
> On Mar 19, 2012, at 9:53 AM, rpluem@apache.org wrote:
> > Modified: httpd/httpd/trunk/modules/proxy/mod_proxy.c
> > URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy.
> c?rev=1302444&r1=1302443&r2=1302444&view=diff
> >
> =======================================================================
> =======
> > --- httpd/httpd/trunk/modules/proxy/mod_proxy.c (original)
> > +++ httpd/httpd/trunk/modules/proxy/mod_proxy.c Mon Mar 19 13:53:28
> 2012
> > @@ -2461,11 +2461,11 @@ static void child_init(apr_pool_t *p, se
> >                 ap_proxy_hashfunc(reverse->s->name,
> PROXY_HASHFUNC_FNV);
> >             /* Do not disable worker in case of errors */
> >             reverse->s->status |= PROXY_WORKER_IGNORE_ERRORS;
> > -            conf->reverse = reverse;
> >             ap_proxy_initialize_worker(conf->reverse, s, conf->pool);
> >             /* Disable address cache for generic reverse worker */
> >             reverse->s->is_address_reusable = 0;
> >         }
> > +        conf->reverse = reverse;
> >         s = s->next;
> >     }
> > }
> >
> 
> Is that right? Doesn't that mean that the ap_proxy_initialize_worker()
> call gets an unknown/undefined 1st arg (conf->reverse)??

Yes :-). The original reporter already pointed that out. Fixed in r1302483.

Regards

Rüdiger