You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/08/22 19:36:22 UTC

[GitHub] [openwhisk] mattwelke opened a new pull request #4947: fix deploy description in readme

mattwelke opened a new pull request #4947:
URL: https://github.com/apache/openwhisk/pull/4947


   Readme appears to have an incorrect description of how the deploy process works when it's a zip file.
   
   ## Description
   I'm not super familiar with OpenWhisk yet, but from tinkering with IBM Cloud Functions, and doing deploys involving both raw source code files and zip archives, this description in the readme doesn't sound accurate. I think what it was meant to say was that the zip archive would have either an executable or one or more Go source code files.
   
   ## Related issue and scope
   - [ ] I opened an issue to propose and discuss this change
   
   ## My changes affect the following components
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   - [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [x] I updated the documentation where necessary.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk] rabbah merged pull request #4947: fix deploy description in readme

Posted by GitBox <gi...@apache.org>.
rabbah merged pull request #4947:
URL: https://github.com/apache/openwhisk/pull/4947


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org