[jira] [Commented] (DAFFODIL-2539) Duplicate TDML file - rename, and remove overlapping tests and schemas

["Steve Lawrence (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DAFFODIL-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372988#comment-17372988 ] 

Steve Lawrence commented on DAFFODIL-2539:
------------------------------------------

I believe this specific tests in "test space/test 1/namespaces.tdml" was testing spaces in the file names, in both the schema and files that those schemas import. The no_namespace_02 test references "multi_base_05_nons.dfdl.xsd", which exists in "test space/test 1/". That file has slight differences from the one in "section06/namespaces". Also, that file xs:include's other files in other directories that all have spaces in the paths (though, nothing in the file name, which also seems important).

So these tests are making sure that tdml files with spaces work, as well as the schemas they reference, as well as the schemas they include. Agree we should make the above changes, but in doing so we need to ensure these cases of files/dirs with spaces are still covered.

> Duplicate TDML file - rename, and remove overlapping tests and schemas
> ----------------------------------------------------------------------
>
>                 Key: DAFFODIL-2539
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2539
>             Project: Daffodil
>          Issue Type: Bug
>          Components: Clean Ups, QA
>    Affects Versions: 3.1.0
>            Reporter: Mike Beckerle
>            Priority: Minor
>              Labels: beginner
>
> There are 2 TDML files under daffodil-test with the same name, similar contents, though they have diverged somewhat.
> Both live under daffodil-test/src/test/resources
> org/apache/daffodil/section06/namespaces/namespaces.tdml
>  "test space/test 1/namespaces.tdml"
> (note how the second one has spaces in the first two path steps.)
> First, this file under test space/test 1 should be renamed. Suggest spacesInNames.tdml
> Second, if you compare the two files, you see they are quite similar, but it looks like the only test in the "test space/test 1" version that has an actual driver scala code calling it, is in section00/general/TestGeneral.scala, test_no_namespace_02.
> All the other tests and any irrelevant define-schemas in this "test space/test 1/namespaces.tdml" should be deleted. This will leave just test_no_namespace_02 and any defineSchema parts needed.
> If those parts exist also in section06/namespaces/namespace.tdml, they should be deleted from that file, so that the resulting two TDML files have no duplicated content, and different names going forward.
> The test name itself should change from test_no_namespace_02 to something more descriptive, like no_namespace_colliding_element_names.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)