You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by bu...@apache.org on 2006/01/19 19:45:45 UTC
DO NOT REPLY [Bug 38321] New: - changed constants from clazz to interfaces
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38321>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38321
Summary: changed constants from clazz to interfaces
Product: Struts
Version: Unknown
Platform: All
OS/Version: All
Status: NEW
Severity: minor
Priority: P3
Component: Shale
AssignedTo: dev@struts.apache.org
ReportedBy: mailings@matthias-wessendorf.de
I changed three classes (containing constants) to an interface
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
DO NOT REPLY [Bug 38321] - changed constants from clazz to interfaces
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38321>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38321
------- Additional Comments From craig.mcclanahan@sun.com 2006-02-05 04:26 -------
(In reply to comment #3)
> (In reply to comment #2)
> > Hmm ... a lot of the reading I've done lately says declaring manifest constants
> > in an interface is an antipattern because it creates a leaky abstraction. What
>
> ah, ok I see. Well I am using (until now ;)) interfaces for kind of this.
> So, that is the reason for UIcomponent is an abstract class?
>
> > is the motivation for this?
>
> I was reading the source, so I *easily* changed ;)
>
> ok, I closed it :-)
(In reply to comment #3)
> (In reply to comment #2)
> > Hmm ... a lot of the reading I've done lately says declaring manifest constants
> > in an interface is an antipattern because it creates a leaky abstraction. What
>
> ah, ok I see. Well I am using (until now ;)) interfaces for kind of this.
> So, that is the reason for UIcomponent is an abstract class?
>
Actually, that was done for a different reason.
Consider what would have happened if we had just defined UIComponent (an
interface) but not UIComponentBase (an abstract class). Now, assume that JSF
1.2 wanted to add some additional methods to UIComponent. This would break
every single third party component in the world -- not a good thing. That's why
nearly all of the APIs in JavaServer Faces are abstract classes rather than
interfaces.
> > is the motivation for this?
>
> I was reading the source, so I *easily* changed ;)
>
> ok, I closed it :-)
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
DO NOT REPLY [Bug 38321] - changed constants from clazz to interfaces
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38321>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38321
------- Additional Comments From craig.mcclanahan@sun.com 2006-02-02 20:01 -------
Hmm ... a lot of the reading I've done lately says declaring manifest constants
in an interface is an antipattern because it creates a leaky abstraction. What
is the motivation for this?
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
DO NOT REPLY [Bug 38321] - changed constants from clazz to interfaces
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38321>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38321
mailings@matthias-wessendorf.de changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |INVALID
------- Additional Comments From mailings@matthias-wessendorf.de 2006-02-02 21:45 -------
(In reply to comment #2)
> Hmm ... a lot of the reading I've done lately says declaring manifest constants
> in an interface is an antipattern because it creates a leaky abstraction. What
ah, ok I see. Well I am using (until now ;)) interfaces for kind of this.
So, that is the reason for UIcomponent is an abstract class?
> is the motivation for this?
I was reading the source, so I *easily* changed ;)
ok, I closed it :-)
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
DO NOT REPLY [Bug 38321] - changed constants from clazz to interfaces
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38321>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38321
------- Additional Comments From mailings@matthias-wessendorf.de 2006-01-19 19:46 -------
Created an attachment (id=17459)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=17459&action=view)
patch
the patch
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org