You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/04/20 20:47:14 UTC

Review Request 58592: Upgrade is not taking care of AMBARI-15677

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58592/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Bugs: AMBARI-20747
    https://issues.apache.org/jira/browse/AMBARI-20747


Repository: ambari


Description
-------

When customer upgraded their Ambari from 2.2.1 to 2.4.1 and HDP 2.3.4 to 2.5.3 
it is not taking care of https://issues.apache.org/jira/browse/AMBARI-15677 RESOLVED bug.
Ambari does not set -XX:CMSInitiatingOccupancyFraction=70 or -XX:+UseCMSInitiatingOccupancyOnly properties.
where as fresh install comes up with these parameters. this needs to be fixed.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 63cf5f5 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 3d8041e 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml fa06291 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml 8b8b9a6 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 2bf6e23 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 97904bf 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml fd75e49 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 5318a51 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml d2e6288 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 2345d08 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml 13f44fb 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml ea261b9 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml de6b8ef 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml fba7093 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 68efed2 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 2ed7962 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml ad936c2 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml d5387c6 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml d46353e 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 1af96dd 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 94aab48 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml ceed59b 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml ce07f7a 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 5b8f53b 


Diff: https://reviews.apache.org/r/58592/diff/1/


Testing
-------

Performed an ugprade from HDP 2.4 to HDP 2.5 with a doctored property. Observed the upgraded value post-upgrade.


Thanks,

Jonathan Hurley

Re: Review Request 58592: Upgrade is not taking care of AMBARI-15677

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58592/#review172552
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On April 20, 2017, 8:47 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58592/
> -----------------------------------------------------------
> 
> (Updated April 20, 2017, 8:47 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-20747
>     https://issues.apache.org/jira/browse/AMBARI-20747
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When customer upgraded their Ambari from 2.2.1 to 2.4.1 and HDP 2.3.4 to 2.5.3 
> it is not taking care of https://issues.apache.org/jira/browse/AMBARI-15677 RESOLVED bug.
> Ambari does not set -XX:CMSInitiatingOccupancyFraction=70 or -XX:+UseCMSInitiatingOccupancyOnly properties.
> where as fresh install comes up with these parameters. this needs to be fixed.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 63cf5f5 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 3d8041e 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml fa06291 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml 8b8b9a6 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 2bf6e23 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 97904bf 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml fd75e49 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 5318a51 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml d2e6288 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 2345d08 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml 13f44fb 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml ea261b9 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml de6b8ef 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml fba7093 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 68efed2 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 2ed7962 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml ad936c2 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml d5387c6 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml d46353e 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 1af96dd 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 94aab48 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml ceed59b 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml ce07f7a 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 5b8f53b 
> 
> 
> Diff: https://reviews.apache.org/r/58592/diff/1/
> 
> 
> Testing
> -------
> 
> Performed an ugprade from HDP 2.4 to HDP 2.5 with a doctored property. Observed the upgraded value post-upgrade.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 58592: Upgrade is not taking care of AMBARI-15677

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58592/#review172606
-----------------------------------------------------------


Ship it!




Ship It!

- Dmitro Lisnichenko


On April 20, 2017, 11:47 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58592/
> -----------------------------------------------------------
> 
> (Updated April 20, 2017, 11:47 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-20747
>     https://issues.apache.org/jira/browse/AMBARI-20747
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When customer upgraded their Ambari from 2.2.1 to 2.4.1 and HDP 2.3.4 to 2.5.3 
> it is not taking care of https://issues.apache.org/jira/browse/AMBARI-15677 RESOLVED bug.
> Ambari does not set -XX:CMSInitiatingOccupancyFraction=70 or -XX:+UseCMSInitiatingOccupancyOnly properties.
> where as fresh install comes up with these parameters. this needs to be fixed.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 63cf5f5 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 3d8041e 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml fa06291 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml 8b8b9a6 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 2bf6e23 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 97904bf 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml fd75e49 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 5318a51 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml d2e6288 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 2345d08 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml 13f44fb 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml ea261b9 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml de6b8ef 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml fba7093 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 68efed2 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 2ed7962 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml ad936c2 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml d5387c6 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml d46353e 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 1af96dd 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 94aab48 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml ceed59b 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml ce07f7a 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 5b8f53b 
> 
> 
> Diff: https://reviews.apache.org/r/58592/diff/1/
> 
> 
> Testing
> -------
> 
> Performed an ugprade from HDP 2.4 to HDP 2.5 with a doctored property. Observed the upgraded value post-upgrade.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>