[jira] [Commented] (HBASE-15324) Jitter may cause desiredMaxFileSize overflow in ConstantSizeRegionSplitPolicy and trigger unexpected split

["Yu Li (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166812#comment-15166812 ] 

Yu Li commented on HBASE-15324:
-------------------------------

Another thing I'd like to mention is that currently there's no attribute in HTableDescriptor to mark a table not splittable, and we have to achieve this by specifying MAX_FILESIZE to Long.MAX_VALUE. I think we could introduce a new attribute like NEVER_SPLIT to make it much easier and straight-forward. Thoughts on this idea? If agreed, I could open another JIRA to implement it. Thanks.

> Jitter may cause desiredMaxFileSize overflow in ConstantSizeRegionSplitPolicy and trigger unexpected split
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15324
>                 URL: https://issues.apache.org/jira/browse/HBASE-15324
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 1.1.3
>            Reporter: Yu Li
>            Assignee: Yu Li
>         Attachments: HBASE-15324.patch
>
>
> We introduce jitter for region split decision in HBASE-13412, but the following line in {{ConstantSizeRegionSplitPolicy}} may cause long value overflow if MAX_FILESIZE is specified to Long.MAX_VALUE:
> {code}
> this.desiredMaxFileSize += (long)(desiredMaxFileSize * (RANDOM.nextFloat() - 0.5D) * jitter);
> {code}
> In our case we specify MAX_FILESIZE to Long.MAX_VALUE to prevent target region to split.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)