[GitHub] [spark] WeichenXu123 commented on a diff in pull request #40520: [SPARK-42896][SQL][PYSPARK] Make `mapInPandas` / `mapInArrow` support barrier mode execution

["WeichenXu123 (via GitHub)" <gi...@apache.org>]

WeichenXu123 commented on code in PR #40520:
URL: https://github.com/apache/spark/pull/40520#discussion_r1144833150


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/MapInPandasExec.scala:
##########
@@ -28,7 +28,8 @@ import org.apache.spark.sql.execution.SparkPlan
 case class MapInPandasExec(
     func: Expression,
     output: Seq[Attribute],
-    child: SparkPlan)
+    child: SparkPlan,
+    override val isBarrier: Boolean)

Review Comment:
   > change via Catalyst Optimizer (e.g., predicate pushdown)
   
   Do you mean pushdown like this ?
   ```
   Filter
     MapInPandas
         XXOp
             ....
   ```
   to
   
   ```
   MapInPandas
     Filter
         XXOp
             ....
   ```
   ?
   
   I don't think we should allow pushdown in this case. `MapInPandas` executes arbitrary user code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org