You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/10/13 09:28:38 UTC
[GitHub] [iotdb] zyk990424 opened a new pull request #4146: fix tag recover bug when upgrade
zyk990424 opened a new pull request #4146:
URL: https://github.com/apache/iotdb/pull/4146
## Description
When upgrade mlog from mlog.txt to mlog.bin, the data of tags and attributes are not read to the mlog.bin which results tagIndex rebuild failure. Thus add tagFile read operation while upgrade mlog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #4146: [To rel/0.12][IOTDB-1837] Fix tagIndex rebuild failure after upgrade mlog from mlog.txt to mlog.bin
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #4146:
URL: https://github.com/apache/iotdb/pull/4146#discussion_r728690837
##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/logfile/MLogWriter.java
##########
@@ -227,13 +229,13 @@ public static void upgradeTxtToBin(
break;
}
try {
- mLogWriter.operation(cmd, isSnapshot);
+ mLogWriter.operation(cmd, isSnapshot, tagLogFile);
} catch (MetadataException e) {
logger.error("failed to upgrade cmd {}.", cmd, e);
}
}
-
// rename .bin.tmp to .bin
+ mLogWriter.close();
Review comment:
Do we need to close the mLogWriter here? It seems that the mLogWriter will close automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #4146: [To rel/0.12][IOTDB-1837] Fix tagIndex rebuild failure after upgrade mlog from mlog.txt to mlog.bin
Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #4146:
URL: https://github.com/apache/iotdb/pull/4146#issuecomment-943069573
Cherry pick to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 merged pull request #4146: [To rel/0.12][IOTDB-1837] Fix tagIndex rebuild failure after upgrade mlog from mlog.txt to mlog.bin
Posted by GitBox <gi...@apache.org>.
wangchao316 merged pull request #4146:
URL: https://github.com/apache/iotdb/pull/4146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org