You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by si...@apache.org on 2008/12/30 02:33:12 UTC
svn commit: r730028 -
/maven/components/trunk/maven-model/src/main/mdo/maven.mdo
Author: sisbell
Date: Mon Dec 29 17:33:12 2008
New Revision: 730028
URL: http://svn.apache.org/viewvc?rev=730028&view=rev
Log:
Fix: MNG-3927
Modified:
maven/components/trunk/maven-model/src/main/mdo/maven.mdo
Modified: maven/components/trunk/maven-model/src/main/mdo/maven.mdo
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-model/src/main/mdo/maven.mdo?rev=730028&r1=730027&r2=730028&view=diff
==============================================================================
--- maven/components/trunk/maven-model/src/main/mdo/maven.mdo (original)
+++ maven/components/trunk/maven-model/src/main/mdo/maven.mdo Mon Dec 29 17:33:12 2008
@@ -2733,7 +2733,7 @@
<name>id</name>
<version>4.0.0</version>
<type>String</type>
- <defaultValue>default</defaultValue>
+ <defaultValue>default-execution-id</defaultValue>
<description>The identifier of this execution for labelling the goals during the build,
and for matching executions to merge during inheritance.</description>
</field>
@@ -2759,7 +2759,7 @@
<version>4.0.0</version>
<code>
<![CDATA[
- public static final String DEFAULT_EXECUTION_ID = "default";
+ public static final String DEFAULT_EXECUTION_ID = "default-execution-id";
]]>
</code>
</codeSegment>
Re: svn commit: r730028 - /maven/components/trunk/maven-model/src/main/mdo/maven.mdo
Posted by Benjamin Bentmann <be...@udo.edu>.
Shane Isbell wrote:
>> Hm, looks odd that the fix for a regression is to break backward-compat
>> somewhere else.
>
> In what way? Where?
The IDs are used to merge <execution>'s during inheritance and profile
injection. So while the both executions
<execution>
<!-- Note missing <id> here -->
<configuration>
...
</configuration>
</execution>
<execution>
<!-- Note explicit reference to default execution id here -->
<id>default</id>
<configuration>
...
</configuration>
</execution>
will merge with Maven 2.x, they will no longer merge in Maven 3.x due to
your recent change.
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r730028 - /maven/components/trunk/maven-model/src/main/mdo/maven.mdo
Posted by Shane Isbell <sh...@gmail.com>.
On Tue, Dec 30, 2008 at 2:47 AM, Benjamin Bentmann <
benjamin.bentmann@udo.edu> wrote:
> Author: sisbell
>> Date: Mon Dec 29 17:33:12 2008
>> New Revision: 730028
>>
>> URL: http://svn.apache.org/viewvc?rev=730028&view=rev
>> Log:
>> Fix: MNG-3927
>>
>> Modified:
>> maven/components/trunk/maven-model/src/main/mdo/maven.mdo
>>
>> Modified: maven/components/trunk/maven-model/src/main/mdo/maven.mdo
>> URL:
>> http://svn.apache.org/viewvc/maven/components/trunk/maven-model/src/main/mdo/maven.mdo?rev=730028&r1=730027&r2=730028&view=diff
>>
>> ==============================================================================
>> --- maven/components/trunk/maven-model/src/main/mdo/maven.mdo (original)
>> +++ maven/components/trunk/maven-model/src/main/mdo/maven.mdo Mon Dec 29
>> 17:33:12 2008
>> @@ -2733,7 +2733,7 @@
>> <name>id</name>
>> <version>4.0.0</version>
>> <type>String</type>
>> - <defaultValue>default</defaultValue>
>> + <defaultValue>default-execution-id</defaultValue>
>> <description>The identifier of this execution for labelling the
>> goals during the build,
>> and for matching executions to merge during
>> inheritance.</description>
>> </field>
>> @@ -2759,7 +2759,7 @@
>> <version>4.0.0</version>
>> <code>
>> <![CDATA[
>> - public static final String DEFAULT_EXECUTION_ID = "default";
>> + public static final String DEFAULT_EXECUTION_ID =
>> "default-execution-id";
>>
>
> Hm, looks odd that the fix for a regression is to break backward-compat
> somewhere else.
In what way? Where?
> Was that really the best option available? What if we change the default
> value for the field "executionId" in o.a.m.l.m.MojoBinding from
> maven-lifecycle instead?
>
>
> Benjamin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: svn commit: r730028 - /maven/components/trunk/maven-model/src/main/mdo/maven.mdo
Posted by Benjamin Bentmann <be...@udo.edu>.
> Author: sisbell
> Date: Mon Dec 29 17:33:12 2008
> New Revision: 730028
>
> URL: http://svn.apache.org/viewvc?rev=730028&view=rev
> Log:
> Fix: MNG-3927
>
> Modified:
> maven/components/trunk/maven-model/src/main/mdo/maven.mdo
>
> Modified: maven/components/trunk/maven-model/src/main/mdo/maven.mdo
> URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-model/src/main/mdo/maven.mdo?rev=730028&r1=730027&r2=730028&view=diff
> ==============================================================================
> --- maven/components/trunk/maven-model/src/main/mdo/maven.mdo (original)
> +++ maven/components/trunk/maven-model/src/main/mdo/maven.mdo Mon Dec 29 17:33:12 2008
> @@ -2733,7 +2733,7 @@
> <name>id</name>
> <version>4.0.0</version>
> <type>String</type>
> - <defaultValue>default</defaultValue>
> + <defaultValue>default-execution-id</defaultValue>
> <description>The identifier of this execution for labelling the goals during the build,
> and for matching executions to merge during inheritance.</description>
> </field>
> @@ -2759,7 +2759,7 @@
> <version>4.0.0</version>
> <code>
> <![CDATA[
> - public static final String DEFAULT_EXECUTION_ID = "default";
> + public static final String DEFAULT_EXECUTION_ID = "default-execution-id";
Hm, looks odd that the fix for a regression is to break backward-compat
somewhere else. Was that really the best option available? What if we
change the default value for the field "executionId" in
o.a.m.l.m.MojoBinding from maven-lifecycle instead?
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org