[jira] [Comment Edited] (ARIA-103) Remove Clint dependency

["Ran Ziv (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARIA-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046557#comment-16046557 ] 

Ran Ziv edited comment on ARIA-103 at 6/12/17 1:30 PM:
-------------------------------------------------------

ARIA-162 is still happening in a sense, because Clint brings an old version of Colorama bundled with its code.
See [this appveyor run|https://ci.appveyor.com/project/ApacheSoftwareFoundation/incubator-ariatosca/build/1.0.1893] for example:

{code}
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "C:\Python27\Lib\atexit.py", line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "c:\projects\incubator-ariatosca\.tox\pywin\lib\site-packages\clint\packages\colorama\initialise.py", line 17, in reset_all
    AnsiToWin32(orig_stdout).reset_all()
  File "c:\projects\incubator-ariatosca\.tox\pywin\lib\site-packages\clint\packages\colorama\ansitowin32.py", line 64, in __init__
    convert = on_windows and is_a_tty(wrapped)
  File "c:\projects\incubator-ariatosca\.tox\pywin\lib\site-packages\clint\packages\colorama\ansitowin32.py", line 15, in is_a_tty
    return hasattr(stream, 'isatty') and stream.isatty()
ValueError: I/O operation on closed file
{code}

Even the latest version of Clint uses a very old Colorama version.
Clint has to go :)


was (Author: ran):
ARIA-162 is still happening in a sense, because Clint brings an old version of Colorama bundled with its code.
See [this appveyor run|https://ci.appveyor.com/project/ApacheSoftwareFoundation/incubator-ariatosca/build/1.0.1893] for example:

{code}
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "C:\Python27\Lib\atexit.py", line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "c:\projects\incubator-ariatosca\.tox\pywin\lib\site-packages\clint\packages\colorama\initialise.py", line 17, in reset_all
    AnsiToWin32(orig_stdout).reset_all()
  File "c:\projects\incubator-ariatosca\.tox\pywin\lib\site-packages\clint\packages\colorama\ansitowin32.py", line 64, in __init__
    convert = on_windows and is_a_tty(wrapped)
  File "c:\projects\incubator-ariatosca\.tox\pywin\lib\site-packages\*clint*\packages\colorama\ansitowin32.py", line 15, in is_a_tty
    return hasattr(stream, 'isatty') and stream.isatty()
ValueError: I/O operation on closed file
{code}

Even the latest version of Clint uses a very old Colorama version.
Clint has to go :)

> Remove Clint dependency
> -----------------------
>
>                 Key: ARIA-103
>                 URL: https://issues.apache.org/jira/browse/ARIA-103
>             Project: AriaTosca
>          Issue Type: Task
>            Reporter: Tal Liron
>            Assignee: Tal Liron
>            Priority: Minor
>
> After some experimentation in other projects I came to the conclusion that Clint is not a very good/stable library. It can easily be replaced with a mix of Blessings+Colorama, which will be more minimal and also work fine on Windows. Our API won't have to change, so nothing will break.
> See my Apache-licensed code here:
> https://github.com/tliron/ronin/blob/master/ronin/utils/messages.py



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)