You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2016/06/02 17:05:36 UTC
Review Request 48175: GEODE-1408: gfsh help alter region output
defaults say '__DEFAULT__'
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48175/
-----------------------------------------------------------
Review request for geode, Jinmei Liao, Karen Miller, Kevin Duling, and Kirk Lund.
Repository: geode
Description
-------
GEODE-1408: gfsh help alter region output defaults say '__DEFAULT__'
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java d27786f72f039448b23af97408061cdd87295bfc
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties 3c0d388d5af2c72864032d9ff0b469ddb4ff4393
Diff: https://reviews.apache.org/r/48175/diff/
Testing
-------
Here is the new help output:
NAME
alter region
IS AVAILABLE
false
SYNOPSIS
Alter a region with the given path and configuration.
SYNTAX
alter region --name=value [--group=value(,value)*] [--entry-idle-time-expiration(=value)?] [--entry-idle-time-expiration-action(=value)?] [--entry-time-to-live-expiration(=value)?] [--entry-time-to-live-expiration-action(=value)?]
[--region-idle-time-expiration(=value)?] [--region-idle-time-expiration-action(=value)?] [--region-time-to-live-expiration(=value)?] [--region-time-to-live-expiration-action(=value)?] [--cache-listener=value(,value)*] [--cache-loader=value]
[--cache-writer=value] [--async-event-queue-id=value(,value)*] [--gateway-sender-id=value(,value)*] [--enable-cloning(=value)?] [--eviction-max(=value)?]
PARAMETERS
name
Name/Path of the region to be altered.
Required: true
group
Group(s) of members on which the region will be altered.
Required: false
entry-idle-time-expiration
How long the region's entries can remain in the cache without being accessed. The default is no expiration of this type.
Required: false
Default (if the parameter is specified without value): -1
entry-idle-time-expiration-action
Action to be taken on an entry that has exceeded the idle expiration.
Required: false
Default (if the parameter is specified without value): INVALIDATE
-->> ^^^^^^^^^^---- new value
entry-time-to-live-expiration
How long the region's entries can remain in the cache without being accessed or updated. The default is no expiration of this type.
Required: false
Default (if the parameter is specified without value): -1
entry-time-to-live-expiration-action
Action to be taken on an entry that has exceeded the TTL expiration.
Required: false
Default (if the parameter is specified without value): INVALIDATE
-->> ^^^^^^^^^^---- new value
region-idle-time-expiration
How long the region can remain in the cache without being accessed. The default is no expiration of this type.
Required: false
Default (if the parameter is specified without value): -1
region-idle-time-expiration-action
Action to be taken on a region that has exceeded the idle expiration.
Required: false
Default (if the parameter is specified without value): INVALIDATE
-->> ^^^^^^^^^^---- new value
region-time-to-live-expiration
How long the region can remain in the cache without being accessed or updated. The default is no expiration of this type.
Required: false
Default (if the parameter is specified without value): -1
region-time-to-live-expiration-action
Action to be taken on a region that has exceeded the TTL expiration.
Required: false
Default (if the parameter is specified without value): INVALIDATE
-->> ^^^^^^^^^^---- new value
cache-listener
Fully qualified class name of a plug-in to be instantiated for receiving after-event notification of changes to the region and its entries. Any number of cache listeners can be configured.
Required: false
-->> No default value shown on this line
cache-loader
Fully qualified class name of a plug-in to be instantiated for receiving notification of cache misses in the region. At most, one cache loader can be defined in each member for the region. For distributed regions, a cache loader may be invoked remotely
from other members that have the region defined.
Required: false
-->> No default value shown on this line
cache-writer
Fully qualified class name of a plug-in to be instantiated for receiving before-event notification of changes to the region and its entries. The plug-in may cancel the event. At most, one cache writer can be defined in each member for the region.
Required: false
async-event-queue-id
IDs of the Async Event Queues that will be used for write-behind operations.
Required: false
gateway-sender-id
IDs of the Gateway Senders to which data will be routed.
Required: false
enable-cloning
Determines how fromDelta applies deltas to the local cache for delta propagation. When true, the updates are applied to a clone of the value and then the clone is saved to the cache. When false, the value is modified in place in the cache.
Required: false
Default (if the parameter is specified without value): false
eviction-max
Maximum value for the Eviction Attributes which the Eviction Algorithm uses to determine when to perform its Eviction Action. The unit of the maximum value is determined by the Eviction Algorithm.
Required: false
Default (if the parameter is specified without value): 0
Thanks,
Jens Deppe
Re: Review Request 48175: GEODE-1408: gfsh help alter region output
defaults say '__DEFAULT__'
Posted by Dave Barnes <db...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48175/#review136006
-----------------------------------------------------------
Ship it!
I believe that the code is correct - it appears to fix the six instances listed in the ticket (JIRA-1408).
The 6 targets were:
- entry-idle-time-expiration-action
- entry-time-to-live-expiration-action
- region-idle-time-expiration-action
- region-time-to-live-expiration-action
- cache-loader
- cache-writer
But for the record, the descriptive review text labeled "Here is the new help output" mistakenly shows a change for cache-listener, which in fact was made (correctly) in the code to cache-writer.
- Dave Barnes
On June 2, 2016, 5:05 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48175/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 5:05 p.m.)
>
>
> Review request for geode, Jinmei Liao, Karen Miller, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1408: gfsh help alter region output defaults say '__DEFAULT__'
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java d27786f72f039448b23af97408061cdd87295bfc
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties 3c0d388d5af2c72864032d9ff0b469ddb4ff4393
>
> Diff: https://reviews.apache.org/r/48175/diff/
>
>
> Testing
> -------
>
> Here is the new help output:
>
> NAME
> alter region
> IS AVAILABLE
> false
> SYNOPSIS
> Alter a region with the given path and configuration.
> SYNTAX
> alter region --name=value [--group=value(,value)*] [--entry-idle-time-expiration(=value)?] [--entry-idle-time-expiration-action(=value)?] [--entry-time-to-live-expiration(=value)?] [--entry-time-to-live-expiration-action(=value)?]
> [--region-idle-time-expiration(=value)?] [--region-idle-time-expiration-action(=value)?] [--region-time-to-live-expiration(=value)?] [--region-time-to-live-expiration-action(=value)?] [--cache-listener=value(,value)*] [--cache-loader=value]
> [--cache-writer=value] [--async-event-queue-id=value(,value)*] [--gateway-sender-id=value(,value)*] [--enable-cloning(=value)?] [--eviction-max(=value)?]
> PARAMETERS
> name
> Name/Path of the region to be altered.
> Required: true
> group
> Group(s) of members on which the region will be altered.
> Required: false
> entry-idle-time-expiration
> How long the region's entries can remain in the cache without being accessed. The default is no expiration of this type.
> Required: false
> Default (if the parameter is specified without value): -1
> entry-idle-time-expiration-action
> Action to be taken on an entry that has exceeded the idle expiration.
> Required: false
> Default (if the parameter is specified without value): INVALIDATE
> -->> ^^^^^^^^^^---- new value
> entry-time-to-live-expiration
> How long the region's entries can remain in the cache without being accessed or updated. The default is no expiration of this type.
> Required: false
> Default (if the parameter is specified without value): -1
> entry-time-to-live-expiration-action
> Action to be taken on an entry that has exceeded the TTL expiration.
> Required: false
> Default (if the parameter is specified without value): INVALIDATE
> -->> ^^^^^^^^^^---- new value
> region-idle-time-expiration
> How long the region can remain in the cache without being accessed. The default is no expiration of this type.
> Required: false
> Default (if the parameter is specified without value): -1
> region-idle-time-expiration-action
> Action to be taken on a region that has exceeded the idle expiration.
> Required: false
> Default (if the parameter is specified without value): INVALIDATE
> -->> ^^^^^^^^^^---- new value
> region-time-to-live-expiration
> How long the region can remain in the cache without being accessed or updated. The default is no expiration of this type.
> Required: false
> Default (if the parameter is specified without value): -1
> region-time-to-live-expiration-action
> Action to be taken on a region that has exceeded the TTL expiration.
> Required: false
> Default (if the parameter is specified without value): INVALIDATE
> -->> ^^^^^^^^^^---- new value
> cache-listener
> Fully qualified class name of a plug-in to be instantiated for receiving after-event notification of changes to the region and its entries. Any number of cache listeners can be configured.
> Required: false
> -->> No default value shown on this line
> cache-loader
> Fully qualified class name of a plug-in to be instantiated for receiving notification of cache misses in the region. At most, one cache loader can be defined in each member for the region. For distributed regions, a cache loader may be invoked remotely
> from other members that have the region defined.
> Required: false
> -->> No default value shown on this line
> cache-writer
> Fully qualified class name of a plug-in to be instantiated for receiving before-event notification of changes to the region and its entries. The plug-in may cancel the event. At most, one cache writer can be defined in each member for the region.
> Required: false
> async-event-queue-id
> IDs of the Async Event Queues that will be used for write-behind operations.
> Required: false
> gateway-sender-id
> IDs of the Gateway Senders to which data will be routed.
> Required: false
> enable-cloning
> Determines how fromDelta applies deltas to the local cache for delta propagation. When true, the updates are applied to a clone of the value and then the clone is saved to the cache. When false, the value is modified in place in the cache.
> Required: false
> Default (if the parameter is specified without value): false
> eviction-max
> Maximum value for the Eviction Attributes which the Eviction Algorithm uses to determine when to perform its Eviction Action. The unit of the maximum value is determined by the Eviction Algorithm.
> Required: false
> Default (if the parameter is specified without value): 0
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 48175: GEODE-1408: gfsh help alter region output
defaults say '__DEFAULT__'
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48175/#review138053
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On June 2, 2016, 5:05 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48175/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 5:05 p.m.)
>
>
> Review request for geode, Jinmei Liao, Karen Miller, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1408: gfsh help alter region output defaults say '__DEFAULT__'
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java d27786f72f039448b23af97408061cdd87295bfc
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties 3c0d388d5af2c72864032d9ff0b469ddb4ff4393
>
> Diff: https://reviews.apache.org/r/48175/diff/
>
>
> Testing
> -------
>
> Here is the new help output:
>
> NAME
> alter region
> IS AVAILABLE
> false
> SYNOPSIS
> Alter a region with the given path and configuration.
> SYNTAX
> alter region --name=value [--group=value(,value)*] [--entry-idle-time-expiration(=value)?] [--entry-idle-time-expiration-action(=value)?] [--entry-time-to-live-expiration(=value)?] [--entry-time-to-live-expiration-action(=value)?]
> [--region-idle-time-expiration(=value)?] [--region-idle-time-expiration-action(=value)?] [--region-time-to-live-expiration(=value)?] [--region-time-to-live-expiration-action(=value)?] [--cache-listener=value(,value)*] [--cache-loader=value]
> [--cache-writer=value] [--async-event-queue-id=value(,value)*] [--gateway-sender-id=value(,value)*] [--enable-cloning(=value)?] [--eviction-max(=value)?]
> PARAMETERS
> name
> Name/Path of the region to be altered.
> Required: true
> group
> Group(s) of members on which the region will be altered.
> Required: false
> entry-idle-time-expiration
> How long the region's entries can remain in the cache without being accessed. The default is no expiration of this type.
> Required: false
> Default (if the parameter is specified without value): -1
> entry-idle-time-expiration-action
> Action to be taken on an entry that has exceeded the idle expiration.
> Required: false
> Default (if the parameter is specified without value): INVALIDATE
> -->> ^^^^^^^^^^---- new value
> entry-time-to-live-expiration
> How long the region's entries can remain in the cache without being accessed or updated. The default is no expiration of this type.
> Required: false
> Default (if the parameter is specified without value): -1
> entry-time-to-live-expiration-action
> Action to be taken on an entry that has exceeded the TTL expiration.
> Required: false
> Default (if the parameter is specified without value): INVALIDATE
> -->> ^^^^^^^^^^---- new value
> region-idle-time-expiration
> How long the region can remain in the cache without being accessed. The default is no expiration of this type.
> Required: false
> Default (if the parameter is specified without value): -1
> region-idle-time-expiration-action
> Action to be taken on a region that has exceeded the idle expiration.
> Required: false
> Default (if the parameter is specified without value): INVALIDATE
> -->> ^^^^^^^^^^---- new value
> region-time-to-live-expiration
> How long the region can remain in the cache without being accessed or updated. The default is no expiration of this type.
> Required: false
> Default (if the parameter is specified without value): -1
> region-time-to-live-expiration-action
> Action to be taken on a region that has exceeded the TTL expiration.
> Required: false
> Default (if the parameter is specified without value): INVALIDATE
> -->> ^^^^^^^^^^---- new value
> cache-listener
> Fully qualified class name of a plug-in to be instantiated for receiving after-event notification of changes to the region and its entries. Any number of cache listeners can be configured.
> Required: false
> -->> No default value shown on this line
> cache-loader
> Fully qualified class name of a plug-in to be instantiated for receiving notification of cache misses in the region. At most, one cache loader can be defined in each member for the region. For distributed regions, a cache loader may be invoked remotely
> from other members that have the region defined.
> Required: false
> -->> No default value shown on this line
> cache-writer
> Fully qualified class name of a plug-in to be instantiated for receiving before-event notification of changes to the region and its entries. The plug-in may cancel the event. At most, one cache writer can be defined in each member for the region.
> Required: false
> async-event-queue-id
> IDs of the Async Event Queues that will be used for write-behind operations.
> Required: false
> gateway-sender-id
> IDs of the Gateway Senders to which data will be routed.
> Required: false
> enable-cloning
> Determines how fromDelta applies deltas to the local cache for delta propagation. When true, the updates are applied to a clone of the value and then the clone is saved to the cache. When false, the value is modified in place in the cache.
> Required: false
> Default (if the parameter is specified without value): false
> eviction-max
> Maximum value for the Eviction Attributes which the Eviction Algorithm uses to determine when to perform its Eviction Action. The unit of the maximum value is determined by the Eviction Algorithm.
> Required: false
> Default (if the parameter is specified without value): 0
>
>
> Thanks,
>
> Jens Deppe
>
>