You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/09/27 02:41:29 UTC

[GitHub] [tinkerpop] divijvaidya opened a new pull request #1334: Simplify Netty reference counting

divijvaidya opened a new pull request #1334:
URL: https://github.com/apache/tinkerpop/pull/1334


   ### Motivation
   We have some incorrect configuration in the code such as:
   1. https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/WebSocketGremlinResponseDecoder.java#L59 (MessageToMessageDecoder automatically decreases the reference count).
   
   1. https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Handler.java#L270 (SimpleChannelInboundHandler automatically decreases the reference count).
   
   which are fixed by hardcoding values such as:
   * https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/WebSocketClientHandler.java#L89
   
   ### Changes
   * Do not release reference count in SimpleChannelInboundHandler and MessageToMessageDecoder since they already do that automatically.
   * Retain references when we want to pass the message to the next handler.
   
   ### Testing
   gremlin-driver `mvn clean install -DskipIntegrationTests=false -DincludeNeo4j`
   gremlin-server `mvn clean install -DskipIntegrationTests=false -DincludeNeo4j`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] divijvaidya merged pull request #1334: TINKERPOP-2427 Simplify Netty reference counting

Posted by GitBox <gi...@apache.org>.
divijvaidya merged pull request #1334:
URL: https://github.com/apache/tinkerpop/pull/1334


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] spmallette commented on pull request #1334: TINKERPOP-2427 Simplify Netty reference counting

Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1334:
URL: https://github.com/apache/tinkerpop/pull/1334#issuecomment-700007900


   Glad you were able to improve this code. The `ctx.fireChannelRead(frame.retain(2));` always bugged me. I'd recommend that you merge to `master` and run tests before merging this as I think you will find some conflict there
   
   VOTE +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org