[GitHub] [helix] pkuwm commented on a change in pull request #1340: Return "name" field as VM name in Azure environment

[GitBox <gi...@apache.org>]

pkuwm commented on a change in pull request #1340:
URL: https://github.com/apache/helix/pull/1340#discussion_r482273331



##########
File path: helix-core/src/main/java/org/apache/helix/cloud/azure/AzureCloudInstanceInformationProcessor.java
##########
@@ -49,14 +49,14 @@
   private final CloseableHttpClient _closeableHttpClient;
   private final HelixCloudProperty _helixCloudProperty;
   private final String COMPUTE = "compute";
-  private final String INSTANCE_NAME = "vmId";
+  private final String INSTANCE_NAME = "name";

Review comment:
       If they are constants, they should be `static final`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org