You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by genged <gi...@git.apache.org> on 2017/10/11 21:18:13 UTC

[GitHub] flink pull request #4810: [FLINK-6926] [table] Add support for MD5,SHA1 and ...

GitHub user genged opened a pull request:

    https://github.com/apache/flink/pull/4810

    [FLINK-6926] [table] Add support for MD5,SHA1 and SHA256 in SQL

    ## What is the purpose of the change
    
    This pull request implements MD5, SHA1 and SHA256 support in Flink SQL as discussed in FLINK-6926
    
    ## Brief change log
    
      - Added MD5, SHA1, SHA256 SQL functions
      - Added relevant unit tests
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
      - Added SQL expression tests
      - Added HashFunctionsTest with testAllApis
      - Validated both correct calculation and behavior for null input
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: don't know
      - The runtime per-record code paths (performance sensitive): don't know
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? yes
      - If yes, how is the feature documented? not documented
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/genged/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4810.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4810
    
----
commit 670ffd0c438a6d519d580a077582121b66b425f5
Author: Michael Gendelman <ge...@gmail.com>
Date:   2017-10-08T21:00:39Z

    [FLINK-6926] [table] Add support for MD5,SHA1 and SHA256 in SQL

----


---

[GitHub] flink issue #4810: [FLINK-6926] [table] Add support for MD5,SHA1 and SHA256 ...

Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/4810
  
    Thank you for the PR @genged. I would throw an exception if the algorithm can not be found and would also move this code into the member part of a Flink `Function`. I will do the final polishing and merge this...


---

[GitHub] flink pull request #4810: [FLINK-6926] [table] Add support for MD5,SHA1 and ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4810


---